Move getting recent requests into a helper method.

1 files changed, 37 insertions, 0 deletions

diff --git a/spec/models/info_request_spec.rb b/spec/models/info_request_spec.rb
index ed7c55bb8..dcc94e967 100644
--- a/spec/models/info_request_spec.rb
+++ b/spec/models/info_request_spec.rb
@@ -1140,4 +1140,41 @@ describe InfoRequest do
 
     end
 
+    describe InfoRequest, 'when constructing the list of recent requests' do
+
+        before(:each) do
+            get_fixtures_xapian_index
+        end
+
+        describe 'when there are fewer than five successful requests' do
+
+            it 'should list the most recently sent and successful requests by the creation date of the
+                request event' do
+                # Make sure the newest response is listed first even if a request
+                # with an older response has a newer comment or was reclassified more recently:
+                # https://github.com/mysociety/alaveteli/issues/370
+                #
+                # This is a deliberate behaviour change, in that the
+                # previous behaviour (showing more-recently-reclassified
+                # requests first) was intentional.
+                request_events, request_events_all_successful = InfoRequest.recent_requests
+                previous = nil
+                request_events.each do |event|
+                    if previous
+                        previous.created_at.should be >= event.created_at
+                    end
+                    ['sent', 'response'].include?(event.event_type).should be_true
+                    if event.event_type == 'response'
+                        ['successful', 'partially_successful'].include?(event.calculated_state).should be_true
+                    end
+                    previous = event
+                end
+            end
+        end
+
+        it 'should coalesce duplicate requests' do
+            request_events, request_events_all_successful = InfoRequest.recent_requests
+            request_events.map(&:info_request).select{|x|x.url_title =~ /^spam/}.length.should == 1
+        end
+    end
 end