Handle validation errors in PublicBody.import_csv

Specifically using save! so that anything other than an
ActiveRecord::RecordInvalid doesn't get missed

Note that ActiveModel::Errors#full_messages includes the attribute key
in the message. This is by design, so we should consider whether we can
improve the way that we use translated validation messages.

1 files changed, 13 insertions, 0 deletions

diff --git a/spec/models/public_body_spec.rb b/spec/models/public_body_spec.rb
index c443f0d6a..38e31783d 100644
--- a/spec/models/public_body_spec.rb
+++ b/spec/models/public_body_spec.rb
@@ -533,6 +533,19 @@ describe PublicBody, " when loading CSV files" do
         PublicBody.count.should == original_count + 3
     end
 
+    it "should handle active record validation errors" do
+        csv = <<-CSV
+#name,request_email,short_name
+Foobar,a@example.com,foobar
+Foobar Test,b@example.com,foobar
+CSV
+
+        csv_contents = normalize_string_to_utf8(csv)
+        errors, notes = PublicBody.import_csv(csv_contents, '', 'replace', true, 'someadmin') # true means dry run
+
+        errors.should include("error: line 3: Url name URL name is already taken for authority 'Foobar Test'")
+    end
+
 end
 
 describe PublicBody do