Merge branch 'release/0.6.4'0.6.4

2 files changed, 32 insertions, 4 deletions

diff --git a/spec/models/info_request_spec.rb b/spec/models/info_request_spec.rb
index 2a738fa4c..c55127992 100644
--- a/spec/models/info_request_spec.rb
+++ b/spec/models/info_request_spec.rb
@@ -353,7 +353,7 @@ describe InfoRequest do
             InfoRequest.should_receive(:find).with(:all,
                   {:select=> anything,
                    :order=> anything,
-                   :conditions=>["awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen' and prominence != 'backpage'",
+                   :conditions=>["awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen' and user_id is not null and prominence != 'backpage'",
                     true, Time.now - 21.days]})
             InfoRequest.find_old_unclassified({:conditions => ["prominence != 'backpage'"]})
         end
@@ -362,7 +362,7 @@ describe InfoRequest do
             InfoRequest.should_receive(:find).with(:all,
                   {:select=>"*, (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) as last_response_time",
                    :order=>"last_response_time",
-                   :conditions=>["awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen'",
+                   :conditions=>["awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen' and user_id is not null",
                     true, Time.now - 21.days]})
             InfoRequest.find_old_unclassified
         end
@@ -396,7 +396,7 @@ describe InfoRequest do
         end
 
         it 'should return true if it is awaiting description, isn\'t the holding pen and hasn\'t had an event in 21 days' do
-            @info_request.is_old_unclassified?.should be_true
+            (@info_request.is_external? || @info_request.is_old_unclassified?).should be_true
         end
 
     end
@@ -484,4 +484,32 @@ describe InfoRequest do
 
     end
 
+    describe 'when an instance is asked if all can view it' do
+
+        before do
+            @info_request = InfoRequest.new
+        end
+
+        it 'should return true if its prominence is normal' do
+            @info_request.prominence = 'normal'
+            @info_request.all_can_view?.should == true
+        end
+
+        it 'should return true if its prominence is backpage' do
+            @info_request.prominence = 'backpage'
+            @info_request.all_can_view?.should == true
+        end
+
+        it 'should return false if its prominence is hidden' do
+            @info_request.prominence = 'hidden'
+            @info_request.all_can_view?.should == false
+        end
+
+        it 'should return false if its prominence is requester_only' do
+            @info_request.prominence = 'requester_only'
+            @info_request.all_can_view?.should == false
+        end
+
+    end
+
 end
diff --git a/spec/models/request_mailer_spec.rb b/spec/models/request_mailer_spec.rb
index 64ac35cf7..ea75ec765 100644
--- a/spec/models/request_mailer_spec.rb
+++ b/spec/models/request_mailer_spec.rb
@@ -223,7 +223,7 @@ describe RequestMailer, "when sending reminders to requesters to classify a resp
     end
 
     it 'should ask for all requests that are awaiting description and whose latest response is older than the number of days given and that are not the holding pen' do
-        expected_params = {:conditions => [ "awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen'",
+        expected_params = {:conditions => [ "awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen' and user_id is not null",
                            true, Time.now() - 7.days ],
                            :include => [ :user ],
                            :order => "info_requests.id"}