diff options
| -rw-r--r-- | app/controllers/admin_user_controller.rb | 10 | ||||
| -rw-r--r-- | app/views/admin_user/show.rhtml | 9 | ||||
| -rw-r--r-- | public/stylesheets/main.css | 1 | ||||
| -rw-r--r-- | todo.txt | 31 |
4 files changed, 33 insertions, 18 deletions
diff --git a/app/controllers/admin_user_controller.rb b/app/controllers/admin_user_controller.rb index f9fe839df..ca69c87b9 100644 --- a/app/controllers/admin_user_controller.rb +++ b/app/controllers/admin_user_controller.rb @@ -4,7 +4,7 @@ # Copyright (c) 2008 UK Citizens Online Democracy. All rights reserved. # Email: francis@mysociety.org; WWW: http://www.mysociety.org/ # -# $Id: admin_user_controller.rb,v 1.6 2008-08-27 00:39:03 francis Exp $ +# $Id: admin_user_controller.rb,v 1.7 2008-09-15 11:11:13 francis Exp $ class AdminUserController < ApplicationController layout "admin" @@ -47,7 +47,13 @@ class AdminUserController < ApplicationController end end - + def destroy_track + track_thing = TrackThing.find(params[:track_id].to_i) + track_thing.destroy + flash[:notice] = 'Track destroyed' + redirect_to user_admin_url(track_thing.tracking_user) + end + private end diff --git a/app/views/admin_user/show.rhtml b/app/views/admin_user/show.rhtml index cf740edfa..fd6733db4 100644 --- a/app/views/admin_user/show.rhtml +++ b/app/views/admin_user/show.rhtml @@ -29,6 +29,7 @@ <th><%= column.human_name %></th> <% end %> <th>Items sent by email</th> + <th>Actions</th> </tr> <% for track_thing in @admin_user.track_things.find(:all, :order => 'created_at desc') %> @@ -38,6 +39,14 @@ <td><%=h track_thing.send(column) %></td> <% end %> <td><%= track_thing.track_things_sent_emails.size %></td> + <td> + <% form_tag '../destroy_track' do %> + <div> + <%= hidden_field_tag 'track_id', track_thing.id %> + <%= submit_tag "Destroy track" %> + </div> + <% end %> + </td> </tr> <% end %> </table> diff --git a/public/stylesheets/main.css b/public/stylesheets/main.css index 4ef8744b9..4297a17ba 100644 --- a/public/stylesheets/main.css +++ b/public/stylesheets/main.css @@ -736,6 +736,7 @@ label.form_label clear: none; text-align: right; padding: 0 10px 0 0; + margin: 0 0 0 0; } #request_form h1 label { @@ -11,6 +11,14 @@ Check foi backup Next ==== +Simple initial bulk request prevention (see Tony's mail on this) +This doesn't work: +http://www.whatdotheyknow.com/search/status:waiting_classification/ +Don't let somebody file a new request if they haven't classified all existing ones? + - nobody will logout and reconfirm email for each one, so can just make it + "can't file while already logged in"? + - and *after* filing get them to go classify existing ones + Maybe move "send followup" into actions? Maybe make it so you need to log in to send follow up (i.e. before) @@ -48,10 +56,6 @@ When forcing auth user for followups is a bit confusing/weird, does it really wo Should we say auth for followups sooner as you have to be certain user? Display of login dialog to log in as particular user if you are logged out isn't centred nicely -Admin: - Somehow fold up the enormous pages on many admin pages - Have internal links to different parts of request page - "Excessive use of speed by Police vehicles." appears only once, even though multiple annotations. Perhaps show grouping count? http://www.whatdotheyknow.com/search/variety:comment/newest @@ -60,10 +64,6 @@ CSS things - CSS error on "all councils" page on some browsers - Spacing on error boxes round form elements - icons for "Things to do with this request" ? - - favicon.ico would be nice -Wrapping of lines like this - are we taking few enough chars per line when wrapping annotations? - http://www.whatdotheyknow.com/request/contract_with_thales_for_nationa#comment-95 - http://www.whatdotheyknow.com/request/marketing_budget_for_id_card_sch_2#outgoing-4110 Merge workflow into one stream - find information, if you can't find it then request it. Show similar requests after you have filed yours - maybe on preview too. @@ -76,14 +76,6 @@ Add "I didn't get the email / spam question" and link to from FOI offcier upload Add "Postal replies stuff" and link to from FOI officer upload page Add "I'm not sure which authority to make my request to" - make flow better after first section, to abrupt now -Simple initial bulk request prevention (see Tony's mail on this) -This doesn't work: -http://www.whatdotheyknow.com/search/status:waiting_classification/ -Don't let somebody file a new request if they haven't classified all existing ones? - - nobody will logout and reconfirm email for each one, so can just make it - "can't file while already logged in"? - - and *after* filing get them to go classify existing ones - Test code for FOI officer upload Grrr - so here I wanted to clarify my request, but don't want the timer to be reset! @@ -92,10 +84,17 @@ Grrr - so here I wanted to clarify my request, but don't want the timer to be re Write code to make sure the Return-Path is never foi@sandwich.org.uk (even if the Rails code breaks for Sendmail case in future botched Rails upgrades :) +Admin: + Somehow fold up the enormous pages on many admin pages + Have internal links to different parts of request page + + Later ===== +favicon.ico would be nice + Flag bad comments, delete comments from admin interface - perhaps via contact form, and form sending refering URL? |