| Commit message (Collapse) | Author | Age | Lines |
|
|
|
| |
http://cl.ly/2w3B2u3o2T1d3u2a0p1o
|
|\ |
|
| |\ |
|
| | | |
|
| |/
| |
| |
| | |
short_or_long_name of a public body
|
| |
| |
| |
| |
| | |
Add the facility to filter the public body feed by event type
using a query string parameter, e.g. event_type=sent.
|
| |
| |
| |
| |
| |
| | |
1. Remove useless call to spec_helper’s basic_auth_login method
2. Use Base64.encode64, rather than b64encode which also prints
the encoded string to standard output.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously the "log in as" function after 3b6e5a692b852a88f55b21a7210f60a6f7cfc24b
would attempt to log the admin user out before issuing the redirect. Unfortunately
this approach does not work on WhatDoTheyKnow, where the admin pages are served via
a different domain (secure.mysociety.org) and so do not share session information with
the rest of the site.
This commit changes it to mark the PostRedirect with circumstance == "login_as",
which signals the user controller to log out the previous user even if they are
an admin. In other words, the user is logged out on the main site rather than the
admin site, skirting this problem.
Closes #450.
|
| |
| |
| |
| | |
Just trailing whitespace & one comment.
|
| |
| |
| |
| | |
Fixes #446. See issue for details.
|
| | |
|
| |
| |
| |
| |
| |
| | |
In the wdtk branch *ONLY* because the deployment system likes
the example file to define the same variables as the actual
config file.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It didn’t seem to work before. (?)
Note that this requires a change to the code as e.g. in
https://github.com/sebbacon/alavetelitheme/blob/master/lib/config/custom-routes.rb
because the route configuration code should not be inside a
Dispatcher.to_prepare block now.
|
| | |
|
| | |
|
| |
| |
| |
| | |
because we want the new version of the survey module.
|
|\| |
|
| |\
| | |
| | |
| | |
| | | |
Conflicts:
README.md
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
commands. Also, don't word-wrap. Includes non-word-wrapped source files.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
all the Exims I've used lately already have a log_selector
setting. This syntax allows us to override that. Otherwise, you get
complaints from Exim.
|
| | |
| | |
| | |
| | |
| | | |
1) Not overriding any *existing* RAILS_ENV setting in rails_env.rb
2) Always creating a rails_env.rb file
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Partially revert 2eac4bef8d73f47bbe579b6f787ef54b8d782d7a, creating
config/rails_env.rb in production only. This should address some of
the difficulties with config/rails_env.rb causing unexpected behaviour
in development, whilst forcing Rails into production environment
where necessary for scripts run from cron etc.
Closes #418?
|
| | |\ |
|
| | | |\ |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #415.
|
| | |/ /
| | | |
| | | |
| | | |
| | | |
| | | | |
Don't change logged-in user from an admin when visiting a auto-login URL.
Closes #306.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Include information about what the per-day limit is, and when the
user can next make a request. Fixes #412.
|
| | | |
| | | |
| | | |
| | | | |
Fixes #413.
|
| |/ /
|/| |
| | |
| | | |
Fixes #407.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Issue #409 seems to be another problem of the same type as #408,
though with the important difference that the bug in this case
is in the test suite rather than the code under test.
RequestMailer sends alert emails warning of overdue requests.
However it does not specify the order that these messages are
sent in, but runs over the overdue requests in whatever order
they are returned by a database query (that does not have an
order by clause). Therefore it is not safe for the test code
to assume that the alert mails will have been sent in a particular
order: just as with #408 it seems that they were *usually* sent
in the order assumed by the test code, but occasionally not --
which would result in sporadic test failures.
Closes #409.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
So it turns out that issue #408 is a real and potentially nasty
bug. The code was assuming that attachments are returned in the
order they were created, which is a) not guaranteed to be the case,
and b) sometimes actually not the case, hence the occasional test
failures.
This trivial patch corrects the issue by sorting attachments by
id. The effect of this is to return them in the order they were
added to the database, since all were added using the same sequence
in a single database session.
Fixes #408.
|
| | | |
|
| | |
| | |
| | |
| | | |
Really, what was that about?
|
| | |
| | |
| | |
| | |
| | | |
Change the test assertions so they give more informative errors
when they fail -- as they sometimes do: see issue #408.
|
|\ \ \ |
|
|\ \ \ \ |
|
| | | |\| |
|
| | | |/
| | |/|
| | | |
| | | | |
can't override it. Fixes #416.
|