| Commit message (Collapse) | Author | Age | Lines |
|\ |
|
| | |
|
|/ |
|
|\ |
|
| | |
|
|/
|
|
|
| |
It is reliable in the case where the script is sourced from another
script.
|
|\ |
|
|/
|
|
| |
Forgot to bump it in 0.37
|
| |
|
|\ |
|
|/ |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Ruby can natively decode uuencoded text with String#unpack. [1] This
avoids the uuencode program dependency and avoids writing tempfiles.
The actual implementation is taken from mail [2]. The UnixToUnix module
is not available in our bundled version of mail.
This commit includes a spec to illustrate the failure of uuencode(1) to
decode the particular attachment in incoming-request-bad-uuencoding-2.
email. Parsing with uuencode returns the following error:
External Command: Error from command "uudecode -o /dev/stdout
/tmp/foiuu20150530-14811-u6j936":
uudecode: /tmp/foiuu20150530-14811-u6j936: No `end' line
The file _is_ created and appears to be OK, but the exit code is 1. This
causes AlaveteliExternalCommand to fail and return nil.
See #2508 [3] for the bug report.
[1] http://ruby-doc.org/core-1.8.7/String.html#method-i-unpack
[2] https://github.com/mikel/mail/blob/bc4c9bb9321e9d36a678692f2f562d3146b63f78/lib/mail/encodings/unix_to_unix.rb#L7
[3] https://github.com/mysociety/alaveteli/issues/2508
|
| |
| |
| |
| |
| | |
each instead of for
remove self
avoid explicit return
|
|/
|
| |
Inspired by https://github.com/mikel/mail/commit/bc4c9bb9321e9d36a678692f2f562d3146b63f78
|
| |
|
|
|
|
|
|
| |
Skipping this seems to have some unexpected interaction with
fixture data.
https://travis-ci.org/mysociety/alaveteli/jobs/64446161
|
|
|
|
| |
Otherwise UTF-8 encoded strings will be returned as ASCII-8BIT.
|
| |
|
|
|
|
| |
Correct indentation to be consistent
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I think I was wrong in a83b379fd2d676172855825d0592937b234371e2 in
assuming that all email gets properly encoded for transfer. Looking
at the mail gem load method
https://github.com/mikel/mail/blob/b159e0a542962fdd5e292a48cfffa560d7cf412e/lib/mail/mail.rb#L175a,
it reads raw email content from a file in binary mode. So this commit
makes both reading and writing the raw_email a binary mode operation
and adds a data_as_text method for displaying the data in the admin
interface that coerces it to valid utf-8.
|
| |
| |
| |
| | |
Move setup to spec - not in common with other specs.
|
| |
| |
| |
| |
| | |
We don't write the data for a raw email to the database anymore.
It's written to a file.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Remove unneeded setup, fixtures are not used in these specs.
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
mb_chars provides a multibyte-aware wrapper for strings. It should
have no effect on ruby 1.9.3 and above. Although ruby 1.8.7 wouldn't
raise errors on a badly sliced multibyte string, on upgrading to ruby
1.9.3 and above, string operations such as gsub, match and join may
produce ArgumentErrors with the message "invalid byte sequence in UTF-8".
Additionally, a database with 'UTF-8' encoding may produce the error
"PG::CharacterNotInRepertoire: ERROR: invalid byte sequence for encoding "UTF8""
|
| |
|
|\
| |
| |
| | |
into hotfix/0.21.0.30
|
| |\ |
|
| | | |
|
| |/
| |
| |
| |
| | |
Mistakenly committed from previous version of
da6c11531a761847ee129f92677a44fdb02de04e
|
| |\ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Stops the RequestMailer trying to send a stopped_responses mail if the
To: address can’t be parsed from the incoming message.
ArgumentError:
An SMTP To address is required to send a message. Set the message
smtp_envelope_to, to, cc, or bcc address.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Prevents mailin exiting with an error code of 75 and sending error
reports to the team@ email address.
|
| |/
| |
| |
| | |
Extract email collection to explaining variable
|
|/
|
|
|
|
|
| |
Without this line, strings created in the file will use the default
external encoding set by the ENV variable LANG. When processes are
forked or run in cron, this may not be preserved, so better to
set explicitly.
|
| |
|