aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Remove summary stats from admin summary pageGareth Rees2015-05-12-23/+4
| | | | | | They're duplicated on /admin/summary and a bit slow [1]. [1] https://wiki.postgresql.org/wiki/Slow_Counting
* Use database attributes to find public_response_eventsGareth Rees2015-05-12-13/+25
| | | | | | user system total real old 1.070000 0.280000 1.350000 ( 1.657773) new 0.560000 0.120000 0.680000 ( 0.743485)
* Remove N+1 QueryGareth Rees2015-05-07-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Removes the following bullet warning: N+1 Query detected PublicBody => [:translations] Add to your finder: :includes => [:translations] N+1 Query method call stack /home/vagrant/alaveteli/app/helpers/link_to_helper.rb:70:in `public_body_url' /home/vagrant/alaveteli/app/helpers/link_to_helper.rb:74:in `public_body_path' /home/vagrant/alaveteli/app/helpers/admin_helper.rb:28:in `public_body_both_links' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:148:in `_app_views_admin_general_index_html_erb__1495531968_70090875267640' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:145:in `each' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:145:in `_app_views_admin_general_index_html_erb__1495531968_70090875267640' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call'
* Use existing attributeGareth Rees2015-05-07-3/+12
| | | | | | | | | | | | | `last_event_time` is set as a result of calling `InfoRequest.find_in_state`. This commit adds an explicit accessor that converts it to a `DateTime` and uses it in the view, preventing an extra query for each `InfoRequest` in the result set. Before: Completed 200 OK in 14908.9ms (Views: 14625.3ms | ActiveRecord: 69.8ms) After: Completed 200 OK in 2481.0ms (Views: 2437.1ms | ActiveRecord: 5.2ms)
* Reduce N+1 queries getting holding pen requestsGareth Rees2015-05-07-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes the following bullet warning: N+1 Query detected IncomingMessage => [:raw_email] Add to your finder: :includes => [:raw_email] N+1 Query method call stack /home/vagrant/alaveteli/app/models/incoming_message.rb:115:in `parse_raw_email!' /home/vagrant/alaveteli/app/models/incoming_message.rb:150:in `sent_at' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:54:in `_app_views_admin_general_index_html_erb___48164640_70115534664600' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:42:in `_app_views_admin_general_index_html_erb___48164640_70115534664600' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call' Improved view rendering times: Before: Completed 200 OK in 2813.9ms (Views: 1697.3ms | ActiveRecord: 9.5ms) Completed 200 OK in 2548.6ms (Views: 1838.2ms | ActiveRecord: 8.2ms) After: Completed 200 OK in 2185.9ms (Views: 276.0ms | ActiveRecord: 7.5ms) Completed 200 OK in 2216.3ms (Views: 100.3ms | ActiveRecord: 7.6ms)
* Line length of holding pen messages sectionGareth Rees2015-05-07-3/+11
|
* Reduce N+1 queries getting update body requestsGareth Rees2015-05-07-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes the following bullet warnings: N+1 Query detected PublicBodyChangeRequest => [:public_body] Add to your finder: :includes => [:public_body] N+1 Query method call stack /home/vagrant/alaveteli/app/models/public_body_change_request.rb:65:in `get_public_body_name' /home/vagrant/alaveteli/app/views/admin_general/_change_request_summary.html .erb:8:in `_app_views_admin_general__change_request_summary_html_erb__490351475_701155 42681500' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:225:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:224:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call' N+1 Query detected PublicBodyChangeRequest => [:user] Add to your finder: :includes => [:user] N+1 Query method call stack /home/vagrant/alaveteli/app/models/public_body_change_request.rb:57:in `get_user_name' /home/vagrant/alaveteli/app/views/admin_general/_change_request_summary.html .erb:46:in `_app_views_admin_general__change_request_summary_html_erb__490351475_701155 42681500' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:225:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:224:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call'
* Reduce N+1 queries getting new body requestsGareth Rees2015-05-07-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes the following Bullet warnings: N+1 Query detected PublicBodyChangeRequest => [:public_body] Add to your finder: :includes => [:public_body] N+1 Query method call stack /home/vagrant/alaveteli/app/models/public_body_change_request.rb:65:in `get_public_body_name' /home/vagrant/alaveteli/app/views/admin_general/_change_request_summary.html .erb:8:in `_app_views_admin_general__change_request_summary_html_erb__490351475_701155 42681500' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:191:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:190:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call' N+1 Query detected PublicBodyChangeRequest => [:user] Add to your finder: :includes => [:user] N+1 Query method call stack /home/vagrant/alaveteli/app/models/public_body_change_request.rb:57:in `get_user_name' /home/vagrant/alaveteli/app/views/admin_general/_change_request_summary.html .erb:46:in `_app_views_admin_general__change_request_summary_html_erb__490351475_701155 42681500' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:191:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/views/admin_general/index.html.erb:190:in `_app_views_admin_general_index_html_erb___48164640_70115537288900' /home/vagrant/alaveteli/app/controllers/application_controller.rb:111:in `record_memory' /home/vagrant/alaveteli/lib/whatdotheyknow/strip_empty_sessions.rb:14:in `call'
* Line length of new bodies sectionGareth Rees2015-05-07-9/+24
|
* Line length of update authorities sectionGareth Rees2015-05-07-7/+24
|
* Improve speed of collecting bodies with no emailGareth Rees2015-05-07-1/+5
| | | | | | user system total real old 0.050000 0.020000 0.070000 ( 0.088856) new 0.020000 0.000000 0.020000 ( 0.018556)
* Merge branch 'remove-obsolete-code' into rails-3-developLouise Crow2015-05-07-9/+0
|\
| * Remove monkeypatch required when running Rails 2.3 under Ruby 1.9Louise Crow2015-05-07-9/+0
| | | | | | | | | | | | This was added because TMail calls String#is_binary_data? which does not exist in Ruby 1.9.2 onwards. We don't use TMail anymore so this is no longer needed.
* | Merge branch 'version-dependent-caching' into rails-3-developLouise Crow2015-05-07-4/+29
|\ \
| * | Force the encoding of values returned from YAML.Louise Crow2015-05-07-3/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a workaround for an issue where YAML in ruby 1.8 tags UTF-8 heavy strings as binary, resulting in them being retrieved under 1.9 as ASCII-8BIT which can't be concatenated with UTF-8. Described as "Deep deep YAML oddness" in https://www.zendesk.com/blog/upgrade-the-road-to-1-9/.
| * | Make the namespace for memcached dependent on ruby version.Louise Crow2015-05-05-1/+2
| |/ | | | | | | Items cached in 1.8 can't safely be retrieved in 1.9
* | Merge branch 'add_bullet' into rails-3-developGareth Rees2015-05-07-1/+24
|\ \
| * | Add bulletGareth Rees2015-05-07-1/+24
|/ / | | | | | | Help to kill N+1 queries and unused eager loading
* | Merge branch 'initialize-info-request' into rails-3-developGareth Rees2015-05-07-26/+152
|\ \
| * | Minor tidy upGareth Rees2015-05-07-11/+8
| | | | | | | | | | | | | | | | | | | | | Remove explicit returns Remove self Ternary for short conditional Moved #site_administration? to be nearer similar methods
| * | Don't load PublicBody when initalizing InfoRequestGareth Rees2015-05-07-3/+23
| | | | | | | | | | | | | | | Doesn't need to try to set the default law_used once it's persisted, so we save a query each time we find an InfoRequest
| * | Extract logic from controllerGareth Rees2015-05-07-13/+6
| | |
| * | Add InfoRequest#move_to_public_bodyGareth Rees2015-05-07-0/+116
|/ /
* | Merge branch 'hotfix/0.21.0.26' into rails-3-developGareth Rees2015-05-06-4/+4
|\ \ | |/ |/|
| * Bump alavetli versionGareth Rees2015-05-06-1/+1
| |
| * Update Nicaragua translattionsGareth Rees2015-05-06-3/+3
| |
* | Merge branch 'mail-server-logs-as-app-user' into rails-3-developLouise Crow2015-04-30-3/+1
|\ \
| * | root no longer required for loading mail logsLouise Crow2015-04-30-3/+1
|/ /
* | Merge branch 'add-alaveteli-user-to-adm' into rails-3-developLouise Crow2015-04-30-0/+3
|\ \
| * | Add the site user to the 'adm' group.Louise Crow2015-04-30-0/+3
|/ / | | | | | | | | This is so that they can access mail log files. adm group members have access to read log files in /var/log
* | Merge branch 'xapian-refactor' into rails-3-developLouise Crow2015-04-30-84/+91
|\ \
| * | Refactor for idiomatic ruby.Louise Crow2015-04-30-15/+18
| | | | | | | | | | | | | | | | | | Use of each rather than for, case statement for multi-clause if, variable interpolation rather than concatenation. Also use inline variables in the each for clarity.
| * | Factor out initialisation of values into its own methodLouise Crow2015-04-29-26/+28
| | |
| * | Factor out term initialisation into its own method.Louise Crow2015-04-29-18/+20
| | |
| * | Use each, identify variables for readability, break up long lines.Louise Crow2015-04-29-13/+16
| | |
| * | Use variable interpolation.Louise Crow2015-04-29-1/+1
| | |
| * | Extract running a job to its own method.Louise Crow2015-04-29-24/+28
| | |
| * | Cleanup spacing.Louise Crow2015-04-29-1/+1
| | |
| * | Use pluck - it's more efficient and concise.Louise Crow2015-04-29-2/+1
| | |
| * | Use empty?, it's more idiomaticLouise Crow2015-04-29-1/+1
| | |
| * | Use a pluck call to get the model namesLouise Crow2015-04-29-1/+1
| | | | | | | | | | | | Clearer, and more efficient.
| * | Use an each blockLouise Crow2015-04-29-4/+1
| | | | | | | | | | | | It's idiomatic, and you can assign the elements of the list inline.
| * | Use respond_to? rather than a begin rescue blockLouise Crow2015-04-29-10/+7
| | | | | | | | | | | | Exceptions are a slow way to do control flow, and this seems clearer.
* | | Merge branch 'rails-3-develop' of ↵Louise Crow2015-04-30-9/+27
|\ \ \ | | | | | | | | | | | | ssh://git.mysociety.org/data/git/public/alaveteli into rails-3-develop
| * \ \ Merge branch 'master' into rails-3-developGareth Rees2015-04-30-1/+1
| |\ \ \ | | | |/ | | |/|
| | * | Bump alaveteli version0.21.0.25Gareth Rees2015-04-30-1/+1
| | | | | | | | | | | | | | | | | | | | Bumping to .25 because I forgot before I merged hotfix 0.21.0.24; treating this as a new hotfix.
| | * | Merge branch 'hotfix/0.21.0.24'0.21.0.24Gareth Rees2015-04-30-8/+26
| | |\ \
| * | \ \ Merge branch 'hotfix/0.21.0.24' into rails-3-developGareth Rees2015-04-30-8/+26
| |\ \ \ \ | | | |/ / | | |/| |
| | * | | Rescue from Holidays::UnknownRegionErrorhotfix/0.21.0.24Gareth Rees2015-04-29-4/+15
| | | | | | | | | | | | | | | | | | | | | | | | | If you run an Alaveteli in a region where we can’t show holiday suggestions the holiday import page breaks. This commit rescues from an unavailable region so that we display a friendly error message.
| | * | | Remove confusing before blockGareth Rees2015-04-29-4/+11
| | |/ / | | | | | | | | | | | | | | | | | | | | Next commit adds a new spec; this before block was affecting the behaviour of the new spec. https://robots.thoughtbot.com/lets-not
generated by cgit v1.2.3 (git 2.25.1) at 2025-09-27 14:53:14 +0000