aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Remove stray puts in test codeRobin Houston2012-01-27-1/+0
| | | | | This was added for temporary debugging purposes, and ought to have been removed.
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-27-17/+35
|\
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-26-118/+140
| |\
| * | Mainly accessibility related changes. Closes issue #367Seb Bacon2012-01-26-17/+35
| | |
* | | Add a trivial test for the list of recent requestsRobin Houston2012-01-27-10/+73
| | |
* | | Refactor test code so new test data can be addedRobin Houston2012-01-26-107/+176
| | | | | | | | | | | | | | | | | | | | | | | | Previously many of the tests made assumptions about the global structure of the test data set: the total number of requests, for example, or the names of all public bodies. This makes it difficult to add to the test data. This change is intended to make the test data easier to extend by eliminating such global assumptions.
* | | No tabs for indentationRobin Houston2012-01-26-1/+1
| | |
* | | indentationRobin Houston2012-01-26-31/+31
| |/ |/|
* | Fix #364 properly: third time lucky!Robin Houston2012-01-26-1/+1
| |
* | Fix #364 properly (?)Robin Houston2012-01-26-1/+1
| |
* | Fix #364Robin Houston2012-01-26-1/+1
| |
* | Clean up the indentationRobin Houston2012-01-26-95/+95
| |
* | Fix #372Robin Houston2012-01-26-11/+27
| |
* | Allow command-line parameters to be passed onRobin Houston2012-01-26-3/+1
| |
* | Remove trailing spacesRobin Houston2012-01-26-1/+1
| |
* | Correct test titleRobin Houston2012-01-25-1/+1
| |
* | Make the load-sample-data script actually workRobin Houston2012-01-25-2/+10
| |
* | Fix the style rules for #everypageRobin Houston2012-01-25-4/+4
|/ | | | Note that #everypage is not used by default.
* Simplify search logic so it doesn't depend on sessions. Also fixes #338Seb Bacon2012-01-25-52/+27
|
* Make sure we show user's alerts on their profile page. Fixes #342Seb Bacon2012-01-25-41/+41
|
* Ensure logo is at the top (because people click on it to get homepage)Seb Bacon2012-01-25-1/+1
|
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-25-94/+188
|\ | | | | | | | | Conflicts: app/controllers/request_controller.rb
| * More test isolationRobin Houston2012-01-24-0/+1
| | | | | | | | | | Towards #361. (Possibly even the very last one!) Fixes: spec/models/xapian_spec.rb spec/integration/search_request_spec.rb
| * More better test isolationRobin Houston2012-01-24-0/+1
| | | | | | | | | | Towards #361. Fixes: spec/models/xapian_spec.rb spec/controllers/user_controller_spec.rb
| * Improve test isolationRobin Houston2012-01-24-0/+2
| | | | | | | | | | Towards #361. Fixes: spec/models/xapian_spec.rb spec/controllers/general_controller_spec.rb
| * Ignore non-matching linesRobin Houston2012-01-24-5/+12
| | | | | | | | | | | | | | When reading a list of test pairs from standard input, ignore lines that do not match the expected format * FAILED: test1 test2
| * A couple more test isolation failuresRobin Houston2012-01-24-0/+2
| | | | | | | | Towards #361
| * Improve test isolationRobin Houston2012-01-24-0/+1
| | | | | | | | Another brick in the wall (#361)
| * Fix sporadic test failureRobin Houston2012-01-24-1/+6
| | | | | | | | Another contribution to #361.
| * Make sure the raw emails are loadedRobin Houston2012-01-24-38/+14
| | | | | | | | | | This fixes (at least) one of the failures in #361, viz spec/controllers/admin_request_controller_spec.rb spec/models/xapian_spec.rb
| * Remove references to removed database columnsRobin Houston2012-01-24-24/+2
| | | | | | | | | | Remove the references to raw_emails.data_text and data_binary, which have not existed since the summer.
| * Remove misleading copy-pasted commentRobin Houston2012-01-24-9/+1
| |
| * Fix a bunch of order-dependent failuresRobin Houston2012-01-24-1/+1
| | | | | | | | This fixes a lot of the failures in #361.
| * Make it possible to test just particular pairsRobin Houston2012-01-24-12/+46
| | | | | | | | | | | | | | For example to re-run all the failed pairs including general_controller_spec.rb: fgrep /general_controller_spec ../test-pair-failures.txt | script/spec-all-pairs -
| * Print successes as well as failuresRobin Houston2012-01-23-2/+7
| | | | | | | | | | As a larger proportion of these tests start to pass, it becomes helpful to print information about successes as well as failures.
| * Add missing fixturesRobin Houston2012-01-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this addition, the "shows a user" test would fail unless run in a context where the public body fixtures had already been loaded, with an error like this: ActionView::TemplateError in 'AdminUserController when administering users shows a user' undefined method `name' for nil:NilClass On line #14 of app/views/admin_request/_some_requests.rhtml 11: <% for info_request in info_requests %> 12: <tr class="<%= cycle('odd', 'even') %>"> 13: <td><%= request_both_links(info_request) %></td> 14: <td><%= public_body_both_links(info_request.public_body) %></td> 15: <td><%= user_both_links(info_request.user) %></td> 16: <% for column in InfoRequest.content_columns.map { |c| c.name } - [ "title", "url_title" ] %> 17: <td><%=h info_request.send(column) %></td>
| * Suppress stderr too, while running testsRobin Houston2012-01-23-1/+1
| |
| * Update commonlib to avoid a possible hangRobin Houston2012-01-23-0/+0
| |
| * Tweaks to spec-all-pairsRobin Houston2012-01-22-7/+4
| | | | | | | | | | 1. Suppress irrelevant output; 2. Check that running the same spec twice doesn’t cause failures either.
| * Script to find order-dependent test failuresRobin Houston2012-01-22-0/+23
| | | | | | | | | | This script runs all (ordered) pairs of tests, and reports which pairs result in a test failure.
| * Improve test isolationRobin Houston2012-01-22-1/+2
| | | | | | | | This test was failing if run after, for example, general_controller_spec.rb.
| * Logging for fragment cacheRobin Houston2012-01-21-0/+2
| |
| * Update commonlib to fix #357Robin Houston2012-01-20-0/+0
| |
| * Remove assumptionRobin Houston2012-01-20-6/+5
| | | | | | | | | | | | | | I feel uncomfortable about the assumption that FastGettext.default_available_locales is always equal to I18n.available_locales. Even if that’s true now, it might not always be -- and if a bug causes them to become erroneously different, the previous code would have masked that.
| * Clear routing filters while tests are runningRobin Houston2012-01-20-0/+10
| | | | | | | | | | | | This fixes a test failure that would show up when running this spec in isolation -- but not necessarily when running all tests, depending on the order they run in.
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-14/+68
| |\
| | * bug fixRobin Houston2012-01-20-1/+1
| | |
| | * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-7/+22
| | |\
| | * | Make sure the FakeWeb registry is kept cleanRobin Houston2012-01-20-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To be fair this change does not seem to make any tests pass that didn’t pass before, but (based on my limited understanding) it seems like a good idea. It also conforms to how FakeWeb is used in application_controller_spec.rb.
| | * | Be sure to restore RoutingFiltersRobin Houston2012-01-20-13/+60
| | | | | | | | | | | | | | | | | | | | | | | | There were some order-dependent test failures that turned out to be caused by the fact that the RoutingFilters were cleared and not subsequently restored, by some tests.