| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
| |
This was added for temporary debugging purposes, and ought to have
been removed.
|
|\ |
|
| |\ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously many of the tests made assumptions about the global
structure of the test data set: the total number of requests, for
example, or the names of all public bodies. This makes it difficult
to add to the test data. This change is intended to make the test
data easier to extend by eliminating such global assumptions.
|
| | | |
|
| |/
|/| |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
Note that #everypage is not used by default.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
app/controllers/request_controller.rb
|
| |
| |
| |
| |
| | |
Towards #361. (Possibly even the very last one!) Fixes:
spec/models/xapian_spec.rb spec/integration/search_request_spec.rb
|
| |
| |
| |
| |
| | |
Towards #361. Fixes:
spec/models/xapian_spec.rb spec/controllers/user_controller_spec.rb
|
| |
| |
| |
| |
| | |
Towards #361. Fixes:
spec/models/xapian_spec.rb spec/controllers/general_controller_spec.rb
|
| |
| |
| |
| |
| |
| |
| | |
When reading a list of test pairs from standard input, ignore lines
that do not match the expected format
* FAILED: test1 test2
|
| |
| |
| |
| | |
Towards #361
|
| |
| |
| |
| | |
Another brick in the wall (#361)
|
| |
| |
| |
| | |
Another contribution to #361.
|
| |
| |
| |
| |
| | |
This fixes (at least) one of the failures in #361, viz
spec/controllers/admin_request_controller_spec.rb spec/models/xapian_spec.rb
|
| |
| |
| |
| |
| | |
Remove the references to raw_emails.data_text and data_binary,
which have not existed since the summer.
|
| | |
|
| |
| |
| |
| | |
This fixes a lot of the failures in #361.
|
| |
| |
| |
| |
| |
| |
| | |
For example to re-run all the failed pairs including
general_controller_spec.rb:
fgrep /general_controller_spec ../test-pair-failures.txt | script/spec-all-pairs -
|
| |
| |
| |
| |
| | |
As a larger proportion of these tests start to pass, it becomes
helpful to print information about successes as well as failures.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this addition, the "shows a user" test would fail unless run in a
context where the public body fixtures had already been loaded, with an
error like this:
ActionView::TemplateError in 'AdminUserController when administering users shows a user'
undefined method `name' for nil:NilClass
On line #14 of app/views/admin_request/_some_requests.rhtml
11: <% for info_request in info_requests %>
12: <tr class="<%= cycle('odd', 'even') %>">
13: <td><%= request_both_links(info_request) %></td>
14: <td><%= public_body_both_links(info_request.public_body) %></td>
15: <td><%= user_both_links(info_request.user) %></td>
16: <% for column in InfoRequest.content_columns.map { |c| c.name } - [ "title", "url_title" ] %>
17: <td><%=h info_request.send(column) %></td>
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
1. Suppress irrelevant output;
2. Check that running the same spec twice doesn’t cause failures either.
|
| |
| |
| |
| |
| | |
This script runs all (ordered) pairs of tests, and reports which pairs
result in a test failure.
|
| |
| |
| |
| | |
This test was failing if run after, for example, general_controller_spec.rb.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
I feel uncomfortable about the assumption that FastGettext.default_available_locales
is always equal to I18n.available_locales. Even if that’s true now, it might not
always be -- and if a bug causes them to become erroneously different, the previous
code would have masked that.
|
| |
| |
| |
| |
| |
| | |
This fixes a test failure that would show up when running this spec
in isolation -- but not necessarily when running all tests, depending
on the order they run in.
|
| |\ |
|
| | | |
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To be fair this change does not seem to make any tests pass that
didn’t pass before, but (based on my limited understanding) it
seems like a good idea. It also conforms to how FakeWeb is used
in application_controller_spec.rb.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There were some order-dependent test failures that turned out to
be caused by the fact that the RoutingFilters were cleared and
not subsequently restored, by some tests.
|