aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Remove assumptionRobin Houston2012-01-20-6/+5
| | | | | | | I feel uncomfortable about the assumption that FastGettext.default_available_locales is always equal to I18n.available_locales. Even if that’s true now, it might not always be -- and if a bug causes them to become erroneously different, the previous code would have masked that.
* Clear routing filters while tests are runningRobin Houston2012-01-20-0/+10
| | | | | | This fixes a test failure that would show up when running this spec in isolation -- but not necessarily when running all tests, depending on the order they run in.
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-14/+68
|\
| * bug fixRobin Houston2012-01-20-1/+1
| |
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-7/+22
| |\
| * | Make sure the FakeWeb registry is kept cleanRobin Houston2012-01-20-0/+7
| | | | | | | | | | | | | | | | | | | | | To be fair this change does not seem to make any tests pass that didn’t pass before, but (based on my limited understanding) it seems like a good idea. It also conforms to how FakeWeb is used in application_controller_spec.rb.
| * | Be sure to restore RoutingFiltersRobin Houston2012-01-20-13/+60
| | | | | | | | | | | | | | | | | | There were some order-dependent test failures that turned out to be caused by the fact that the RoutingFilters were cleared and not subsequently restored, by some tests.
* | | Improved test isolationRobin Houston2012-01-20-0/+4
| |/ |/| | | | | | | The test “AdminRequestController when administering requests shows a public body” would fail when this spec is run on its own twice in succession.
* | Don't allow users to page beyond a certain number of results (because in ↵Seb Bacon2012-01-20-7/+22
|/ | | | large databases, the sorting of such large batches causes an extreme slowdown).
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-19-4/+4
|\
| * Merge branch 'wdtk' of https://github.com/sebbacon/alaveteli into wdtkRobin Houston2012-01-19-2/+2
| |\
| | * Share a lock file between processes that modify the xapian database. Avoids ↵Seb Bacon2012-01-19-2/+2
| | | | | | | | | | | | a race condition and fixes #304
| * | Don't obscure user searches on request listing page behind cache. Fixes #256Robin Houston2012-01-19-2/+2
| |/
* / Record URL and PID *before* a request is processedRobin Houston2012-01-19-0/+1
|/ | | | | | | (If DEBUG_RECORD_MEMORY is enabled) This is useful for tracking down bugs that cause Rails to go into an infinite or very long loop, as the recent Xapian wildcard bug does.
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-19-1/+10
|\
| * Do not require Xapian 1.2.7Robin Houston2012-01-19-1/+10
| | | | | | | | Work (with subtly reduced resilience) on earlier versions.
* | Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-19-40/+116
|\|
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-19-22/+83
| |\
| | * Merge branch 'release/0.5' into wdtkRobin Houston2012-01-19-17/+64
| | |\ | | | | | | | | | | | | | | | | Conflicts: app/views/public_body/_search_ahead.rhtml
| | | * Return a 404 for broken attachment urls. Fixes #351.Seb Bacon2012-01-18-1/+12
| | | |
| | | * Don't raise an error if the user deletes a track through the UI. Fixes #353.Seb Bacon2012-01-18-8/+14
| | | |
| | | * Fix more test breakageSeb Bacon2012-01-18-3/+12
| | | |
| | | * Catch timeouts and other extra errors when connection to 3rd party websites ↵Seb Bacon2012-01-18-2/+9
| | | | | | | | | | | | | | | | fails.
| | | * Ensure request typeahead search is tested properly (and fix a validation error).Seb Bacon2012-01-18-1/+3
| | | |
| | | * Merge branch 'release/0.5' of github.com:sebbacon/alaveteli into release/0.5Seb Bacon2012-01-18-36/+45
| | | |\
| | | * | Fix paging bug for type ahead search. This wasn't caught because the spec ↵Seb Bacon2012-01-18-5/+16
| | | | | | | | | | | | | | | | | | | | didn't call "integrate_views", so the rendering part was mocked by RSpec instead of executed.
| | * | | Merge branch 'wdtk' of https://github.com/sebbacon/alaveteli into wdtkRobin Houston2012-01-19-11/+18
| | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: app/controllers/application_controller.rb
| | * | | | Limit Xapian wildcard expansionsRobin Houston2012-01-19-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wildcard searches in Xapian can expand uncontrollably, consuming all available RAM and crashing the server. This has been a real problem on WhatDoTheyKnow.com. The underlying issue is tracked in http://trac.xapian.org/ticket/350 This changeset imposes a limit on wildcard expansion. The type-ahead search will first try a wildcard query, and if that fails because of too much expansion will fall back to a plain non-wildcard search.
| * | | | | Fix sporadic spurious test failuresRobin Houston2012-01-19-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...by forcing the IncomingMessage to be re-parsed after we have edited it.
| * | | | | Typo fixRobin Houston2012-01-19-1/+1
| | | | | |
| * | | | | Whitespace cleanupRobin Houston2012-01-19-6/+6
| | |/ / / | |/| | |
| * | | | Forbid very slow-to-load results pagesRobin Houston2012-01-19-0/+7
| | | | | | | | | | | | | | | | | | | | Another temporary patch to protect the live site.
| * | | | Disable Xapian wildcardsRobin Houston2012-01-19-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do not use FLAG_WILDCARD or FLAG_PARTIAL anywhere, because wildcard searches can crash the whole server as per http://trac.xapian.org/ticket/350 (e.g. http://www.whatdotheyknow.com/body/search_ahead?query=app will crash the server prior to this commit.) This is a temporary fix while we investigate the possibilities of the set_max_wildcard_expansion() method, which should make it possible to alleviate this issue.
| * | | | Clean up whitespace & indentationRobin Houston2012-01-18-10/+10
| |/ / /
* | | | Show some info about the Alaveteli version currently running. Fixes #319.Seb Bacon2012-01-19-0/+8
| | | |
* | | | Use an atomic write when storing email data.Seb Bacon2012-01-19-1/+1
| | | |
* | | | Don't choke on very long filenames when caching attachments. Fixes #349.Seb Bacon2012-01-19-1/+13
| | | |
* | | | Always show the right search snippet. Fixes #352.Seb Bacon2012-01-19-1/+28
|/ / /
* | | Also disable paging for type-ahead search resultsRobin Houston2012-01-17-1/+0
| | | | | | | | | | | | Same problem as previous commit to this (wdtk) branch.
* | | Disable paginationRobin Houston2012-01-17-1/+0
| |/ |/| | | | | | | Pagination for authority search results in the new request workflow seems to be broken very badly, so disable it for now.
* | Merge branch 'wdtk' into release/0.5Robin Houston2012-01-17-36/+45
|\ \ | |/ |/|
| * Force the 'C' locale for elinksRobin Houston2012-01-17-3/+3
| | | | | | | | | | The behaviour of elinks is locale-dependent. This patch forces LANG=C which makes the behaviour consistent across platforms.
| * Comment typoRobin Houston2012-01-17-1/+1
| |
| * Upgrade commonlibRobin Houston2012-01-17-0/+0
| | | | | | | | Because we want the new version of external_command.rb
| * Explicitly specify little-endian UCS-2Robin Houston2012-01-17-2/+2
| | | | | | | | | | because for some reason iconv is assuming big-endian on my MacBook Pro (OS X 10.7.2) unless told explicitly, and this causes test failure.
| * Flexible location for validate utilityRobin Houston2012-01-17-3/+11
| | | | | | | | | | Allow the WDG HTML validation utility "validate" to be anywhere in UTILITY_SEARCH_PATH, rather than hard-coding /usr/bin.
| * Use AlaveteliExternalCommand for unrtfRobin Houston2012-01-17-3/+1
| |
| * Use AlaveteliExternalCommand for pdf recompressionRobin Houston2012-01-17-7/+3
| |
| * Replace all `which command` callsRobin Houston2012-01-17-14/+10
| | | | | | | | | | | | | | | | | | | | The trouble with `which command` is twofold: - It spawns a whole shell just to find out the path to a binary, every time; - The results are environment-dependent, since they depend on $PATH. It would be better to specify the search path in the configuration file where everything else is specified rather than in the environment. This commit replaces it with the new mechanism from AlaveteliExternalCommand.
| * Typo whoopsRobin Houston2012-01-17-1/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2025-09-05 08:49:24 +0000