aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
* Add new code and specs for hiding attachments.Louise Crow2013-09-16-12/+139
|
* Refactor expectation into a methodLouise Crow2013-09-16-6/+8
| | | | Remove expectation of pdf contents - we're looking at the raw file.
* Use a real pdf file for foi_attachment factory.Louise Crow2013-09-16-2/+2
|
* Refactor prominence specs to use factories not fixtures.Louise Crow2013-09-16-117/+133
|
* Clarify specs.Louise Crow2013-09-16-5/+5
| | | | They refer to the case where the request itself is hidden.
* Handle the case of an empty string in the prominence_reason.Louise Crow2013-09-16-3/+3
| | | | | | | | | This will happen if the prominence has been changed in the admin interface but no reason has been filled in. Conflicts: app/views/request/_incoming_correspondence.html.erb
* Add a possible event type 'edit_incoming'.Louise Crow2013-09-16-1/+1
| | | | This will cover changes in prominence to incoming messages.
* Add the meat of the update action.Louise Crow2013-09-16-0/+89
|
* Link to the new incoming message edit form.Louise Crow2013-09-16-1/+6
| | | | From the request admin page.
* I don't think there's any need to refind incoming messages.Louise Crow2013-09-16-1/+1
| | | | The order is the same as the default association.
* Use new partial for incoming message admin boilerplate.Louise Crow2013-09-16-5/+1
|
* Add a simple edit action and templateLouise Crow2013-09-16-5/+61
|
* Make some simple factories for real objects.Louise Crow2013-09-16-0/+33
|
* Add factory_girl gemLouise Crow2013-09-16-0/+7
| | | | | Hopefully transitioning from fixtures to factories will mean faster running tests over time.
* Realphabetize.Louise Crow2013-09-16-10/+10
|
* Shorter route names and pathsLouise Crow2013-09-16-14/+14
|
* Add incoming message update action and route.Louise Crow2013-09-16-0/+4
| | | | | We'll use this for saving the changes to the prominence of an incoming message in a relatively RESTful url structure.
* Make prominence states a constant so we can access them elsewhere.Louise Crow2013-09-16-5/+2
|
* Slightly nicer action names.Louise Crow2013-09-16-9/+9
|
* Move incoming message admin to its own controller.Louise Crow2013-09-16-130/+165
| | | | | Make specs that depend on multiple controllers and models interacting integration specs.
* Move outgoing message admin actions to their own controller.Louise Crow2013-09-16-48/+65
| | | | Eventually this should use standard RESTful routing.
* Don't index hidden and requester_only incoming messages.Louise Crow2013-09-16-0/+72
|
* Remove unused hidden correspondence template.Louise Crow2013-09-16-33/+0
|
* Add prominence reason.Louise Crow2013-09-16-9/+22
| | | | | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb Conflicts: spec/integration/view_request_spec.rb
* Adding prominence_reason to IncomingMessage.Louise Crow2013-09-16-0/+8
|
* Add messages for hidden and requester_only states.Louise Crow2013-09-16-19/+128
| | | | Different messages for normal user, requester and admin user.
* Refactor some common setup steps in integration tests into a DSL.Louise Crow2013-09-16-60/+114
| | | | Add a failing test for what should happen on request hiding.
* Refactor common logic about prominence and access.Louise Crow2013-09-16-16/+15
| | | | Move it into the Ability module.
* Add a method to ask whether a user can view an incoming message.Louise Crow2013-09-16-0/+67
|
* Rename method to make it a bit more genericLouise Crow2013-09-16-5/+5
| | | | A super user will be able to see all hidden things, not just requests.
* Refactor correspondence template into partials.Louise Crow2013-09-16-81/+63
|
* Add response_event helperLouise Crow2013-09-16-0/+18
| | | | | Add a convenience method for getting the 'response' event associated with an incoming message.
* Add prominence to incoming message.Louise Crow2013-09-16-0/+34
|
* Re-annotate models with database fieldsLouise Crow2013-09-16-143/+561
|
* Remove prominence.Louise Crow2013-09-16-36/+10
| | | | | | | Add a migration to remove the unused column 'prominence' from info_request_events, remove validation of prominence, remove unused InfoRequestEvent.user_can_view? method. Remove references to InfoRequestEvent.prominence.
* Preserve string "Tags (separated by a space):", removed in ↵Louise Crow2013-07-31-1/+1
| | | | f89e2c3d5cee5e3bf2bd2227254fa0edb09aeb53, as there are lots of translations for this already, and we'll probably be re-introducing it with more features around tagging.
* Remove unused line of codeLouise Crow2013-07-30-1/+0
|
* Use first argument to script when not running in daemon mode. Fixes #1023.Louise Crow2013-07-30-1/+1
|
* Add some notes about how to fix existing email addresses with spaces.Louise Crow2013-07-30-2/+1
|
* Add a note on how to start mailcatcher.Louise Crow2013-07-30-1/+2
|
* Handle the case of a name that hits the character limits and has been ↵Louise Crow2013-07-29-7/+27
| | | | suffixed with a number.
* Update commonlib to get fix for ↵Louise Crow2013-07-29-0/+6
| | | | https://github.com/mysociety/alaveteli/issues/282 and https://github.com/opennorth/alaveteli/issues/2. Note, this will not fix https://github.com/mysociety/alaveteli/issues/902, which would require a change in request title validation in https://github.com/mysociety/alaveteli/blob/rails-3-develop/app/models/info_request.rb#L34.
* Merge branch 'feature/localisation-fixes' into rails-3-developLouise Crow2013-07-29-168/+190
|\
| * Prepare the xapian database before running tests that rely on it existing.Louise Crow2013-07-29-0/+5
| |
| * Move some more config into AlaveteliLocalization so that it can be called ↵Louise Crow2013-07-24-13/+14
| | | | | | | | outside initialization e.g. in tests.
| * Clarify comment.Louise Crow2013-07-23-1/+1
| |
| * Use FastGettext.locale, not I18n.locale as the latter will return hyphens, ↵Louise Crow2013-07-23-1/+1
| | | | | | | | not underscores as we use in our URLs.
| * Patch Globalize to compensate for the way gettext_i18n_rails patches ↵Louise Crow2013-07-23-6/+49
| | | | | | | | 118n.locale in the handling of locales with underscores. Fixes #999.
| * Add loading of raw emails - test depends on this.Louise Crow2013-07-23-0/+1
| |
| * Use AlaveteliConfiguration wrapper in test so we can be more specific about ↵Louise Crow2013-07-23-1/+1
| | | | | | | | the method to be stubbed and avoid side effects.