| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
| |
Either rails or the webserver will be sending it, we're not redirecting
anymore.
|
|
|
|
|
| |
So that files attached to different messages with the same name and
url_part don't get overwritten.
|
| |
|
| |
|
|
|
|
| |
Versions of factory_girl after 3 are not compatible with ruby 1.8.7
|
|
|
|
|
|
| |
Add the 'Actions' to the incoming message admin - now that this has both
this and the prominence form, it seems like the logical place to link to
from the main request page.
|
|
|
|
|
| |
Make old_unclassified_params method consistent with
last_public_response_event and associated methods.
|
| |
|
|
|
|
|
|
|
| |
get_last_response_event and get_last_outgoing_event are used in various
places to determine which events to link to, use in queries etc.
Restrict them to refer to the last publicly visible event of the
relevant type, and rename them to make that clear.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Add some tests that it's working on the outgoing message model.
|
| |
|
|
|
|
|
|
| |
Conflicts:
app/views/request/_incoming_correspondence.html.erb
|
|
|
|
|
|
| |
At least some of the logic for incoming and outgoing message prominence
is going to be identical, so move it to a module they can both include
and use.
|
|
|
|
|
| |
Add some sequences to make sure that we don't get validation errors on
unique fields.
|
|
|
|
|
|
| |
Conflicts:
spec/integration/view_request_spec.rb
|
| |
|
| |
|
|
|
|
| |
We want to be able to authorise access to it.
|
| |
|
|
|
|
|
|
| |
Use send_file to send zips. Also adds 'all_can_view_all_correspondence?'
- is this request completely cachable, or do we need to cache different
versions for different levels of privilege?
|
| |
|
|
|
|
| |
By default, give an incoming message a body attachment.
|
|
|
|
|
|
| |
This was disabled for hidden requests as the download was by redirect,
allowing people who have not been authenticated to conceivably access
the download. We'll be moving to send_file instead, so can restore it.
|
|
|
|
|
| |
The third (and any subsequent) session created shares a session id with
the second without this explicit reset.
|
|
|
|
| |
We're testing the code path where there is no converter here.
|
| |
|
|
|
|
|
|
| |
This should be handled by assign_variables_for_show_template. Otherwise,
the make_request_summary_file method shouldn't depend on instance
variables
|
| |
|
| |
|
|
|
|
|
|
|
| |
Adds a spec for what we want to see - no message text in
correspondence.txt, and no attachments. Refactors the
simple_correspondence templates to make it clearer that these are doing
the same job as the html.erb ones, for text.
|
|
|
|
|
|
|
|
|
| |
Each part is a separate sentence, and we're going to reuse some of them
in the text view.
Conflicts:
spec/integration/view_request_spec.rb
|
|
|
|
| |
We're about to reuse them for the text view.
|
|
|
|
|
|
| |
Conflicts:
app/views/request/_incoming_correspondence.html.erb
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Render the show template within the current thread rather than making
another request - we're going to need to use the current session in
order to know what do include in the zip file, now that we have more
fine-grained visibility of messages. Also, this will mean we can use
this functionality in single threaded contexts, and test it more easily.
Don't display profile photos as this would require another process, and
hide other icons so we don't need to include them. Use render_to_string
as a more standard way of rendering templates to a string for further
manipulation.
|
|
|
|
|
|
| |
So we can reuse them when rendering the show template to a file. Lots of
the sidebar prep isn't going to be needed for that view, so make that
optional in the template.
|
|
|
|
|
| |
Split into those that come from request params and those that come from
the model
|
|
|
|
| |
Also, store an event for the incoming message.
|
|
|
|
|
| |
Make it an integration spec so we don't need to touch the internals so
much.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Add another spec for the same behaviour when an incoming message is
hidden.
|