Commit message (Collapse) | Author | Age | Lines | |
---|---|---|---|---|
* | Move display text generation to outgoing message. | Louise Crow | 2013-09-16 | -5/+9 |
| | ||||
* | Remove hidden incoming messages from correspondence.txt | Louise Crow | 2013-09-16 | -46/+80 |
| | | | | | | | Adds a spec for what we want to see - no message text in correspondence.txt, and no attachments. Refactors the simple_correspondence templates to make it clearer that these are doing the same job as the html.erb ones, for text. | |||
* | Split up translated messages. | Louise Crow | 2013-09-16 | -7/+16 |
| | | | | | | | | | Each part is a separate sentence, and we're going to reuse some of them in the text view. Conflicts: spec/integration/view_request_spec.rb | |||
* | Move a couple of complex conditionals to helper methods. | Louise Crow | 2013-09-16 | -2/+11 |
| | | | | We're about to reuse them for the text view. | |||
* | Remove unused param. | Louise Crow | 2013-09-16 | -1/+1 |
| | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb | |||
* | Normalize method spacing. | Louise Crow | 2013-09-16 | -0/+3 |
| | ||||
* | Extract calculation of last update hash | Louise Crow | 2013-09-16 | -2/+5 |
| | ||||
* | Extract out code for making a request summary file | Louise Crow | 2013-09-16 | -50/+69 |
| | | | | | | | | | | | | Render the show template within the current thread rather than making another request - we're going to need to use the current session in order to know what do include in the zip file, now that we have more fine-grained visibility of messages. Also, this will mean we can use this functionality in single threaded contexts, and test it more easily. Don't display profile photos as this would require another process, and hide other icons so we don't need to include them. Use render_to_string as a more standard way of rendering templates to a string for further manipulation. | |||
* | Extract the various info_request assigns | Louise Crow | 2013-09-16 | -10/+16 |
| | | | | | | So we can reuse them when rendering the show template to a file. Lots of the sidebar prep isn't going to be needed for that view, so make that optional in the template. | |||
* | Reorder assigns | Louise Crow | 2013-09-16 | -12/+12 |
| | | | | | Split into those that come from request params and those that come from the model | |||
* | Give incoming message factory a body text. | Louise Crow | 2013-09-16 | -9/+21 |
| | | | | Also, store an event for the incoming message. | |||
* | Rewrite download spec | Louise Crow | 2013-09-16 | -47/+76 |
| | | | | | Make it an integration spec so we don't need to touch the internals so much. | |||
* | Allow an actual user to be passed to the login method. | Louise Crow | 2013-09-16 | -1/+5 |
| | ||||
* | Replace fixture-based spec with factory-based equivalent. | Louise Crow | 2013-09-16 | -10/+6 |
| | ||||
* | Use expectation for hidden responses more generally. | Louise Crow | 2013-09-16 | -9/+9 |
| | ||||
* | Fix request in spec for hidden attachments not being viewed. | Louise Crow | 2013-09-16 | -2/+15 |
| | | | | | Add another spec for the same behaviour when an incoming message is hidden. | |||
* | Add new code and specs for hiding attachments. | Louise Crow | 2013-09-16 | -12/+139 |
| | ||||
* | Refactor expectation into a method | Louise Crow | 2013-09-16 | -6/+8 |
| | | | | Remove expectation of pdf contents - we're looking at the raw file. | |||
* | Use a real pdf file for foi_attachment factory. | Louise Crow | 2013-09-16 | -2/+2 |
| | ||||
* | Refactor prominence specs to use factories not fixtures. | Louise Crow | 2013-09-16 | -117/+133 |
| | ||||
* | Clarify specs. | Louise Crow | 2013-09-16 | -5/+5 |
| | | | | They refer to the case where the request itself is hidden. | |||
* | Handle the case of an empty string in the prominence_reason. | Louise Crow | 2013-09-16 | -3/+3 |
| | | | | | | | | | This will happen if the prominence has been changed in the admin interface but no reason has been filled in. Conflicts: app/views/request/_incoming_correspondence.html.erb | |||
* | Add a possible event type 'edit_incoming'. | Louise Crow | 2013-09-16 | -1/+1 |
| | | | | This will cover changes in prominence to incoming messages. | |||
* | Add the meat of the update action. | Louise Crow | 2013-09-16 | -0/+89 |
| | ||||
* | Link to the new incoming message edit form. | Louise Crow | 2013-09-16 | -1/+6 |
| | | | | From the request admin page. | |||
* | I don't think there's any need to refind incoming messages. | Louise Crow | 2013-09-16 | -1/+1 |
| | | | | The order is the same as the default association. | |||
* | Use new partial for incoming message admin boilerplate. | Louise Crow | 2013-09-16 | -5/+1 |
| | ||||
* | Add a simple edit action and template | Louise Crow | 2013-09-16 | -5/+61 |
| | ||||
* | Make some simple factories for real objects. | Louise Crow | 2013-09-16 | -0/+33 |
| | ||||
* | Add factory_girl gem | Louise Crow | 2013-09-16 | -0/+7 |
| | | | | | Hopefully transitioning from fixtures to factories will mean faster running tests over time. | |||
* | Realphabetize. | Louise Crow | 2013-09-16 | -10/+10 |
| | ||||
* | Shorter route names and paths | Louise Crow | 2013-09-16 | -14/+14 |
| | ||||
* | Add incoming message update action and route. | Louise Crow | 2013-09-16 | -0/+4 |
| | | | | | We'll use this for saving the changes to the prominence of an incoming message in a relatively RESTful url structure. | |||
* | Make prominence states a constant so we can access them elsewhere. | Louise Crow | 2013-09-16 | -5/+2 |
| | ||||
* | Slightly nicer action names. | Louise Crow | 2013-09-16 | -9/+9 |
| | ||||
* | Move incoming message admin to its own controller. | Louise Crow | 2013-09-16 | -130/+165 |
| | | | | | Make specs that depend on multiple controllers and models interacting integration specs. | |||
* | Move outgoing message admin actions to their own controller. | Louise Crow | 2013-09-16 | -48/+65 |
| | | | | Eventually this should use standard RESTful routing. | |||
* | Don't index hidden and requester_only incoming messages. | Louise Crow | 2013-09-16 | -0/+72 |
| | ||||
* | Remove unused hidden correspondence template. | Louise Crow | 2013-09-16 | -33/+0 |
| | ||||
* | Add prominence reason. | Louise Crow | 2013-09-16 | -9/+22 |
| | | | | | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb Conflicts: spec/integration/view_request_spec.rb | |||
* | Adding prominence_reason to IncomingMessage. | Louise Crow | 2013-09-16 | -0/+8 |
| | ||||
* | Add messages for hidden and requester_only states. | Louise Crow | 2013-09-16 | -19/+128 |
| | | | | Different messages for normal user, requester and admin user. | |||
* | Refactor some common setup steps in integration tests into a DSL. | Louise Crow | 2013-09-16 | -60/+114 |
| | | | | Add a failing test for what should happen on request hiding. | |||
* | Refactor common logic about prominence and access. | Louise Crow | 2013-09-16 | -16/+15 |
| | | | | Move it into the Ability module. | |||
* | Add a method to ask whether a user can view an incoming message. | Louise Crow | 2013-09-16 | -0/+67 |
| | ||||
* | Rename method to make it a bit more generic | Louise Crow | 2013-09-16 | -5/+5 |
| | | | | A super user will be able to see all hidden things, not just requests. | |||
* | Refactor correspondence template into partials. | Louise Crow | 2013-09-16 | -81/+63 |
| | ||||
* | Add response_event helper | Louise Crow | 2013-09-16 | -0/+18 |
| | | | | | Add a convenience method for getting the 'response' event associated with an incoming message. | |||
* | Add prominence to incoming message. | Louise Crow | 2013-09-16 | -0/+34 |
| | ||||
* | Re-annotate models with database fields | Louise Crow | 2013-09-16 | -143/+561 |
| |