aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* InfoRequestEvent.indexed_by_search consults OutgoingMessage.Louise Crow2013-09-16-1/+21
|
* Move indexed_by_search to MessageProminenceLouise Crow2013-09-16-6/+27
| | | | Add some tests that it's working on the outgoing message model.
* Add some tests for user_can_view? on outgoing message.Louise Crow2013-09-16-0/+52
|
* Add hidden messages for outgoing message.Louise Crow2013-09-16-32/+79
| | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb
* Create MessageProminence module.Louise Crow2013-09-16-7/+22
| | | | | | At least some of the logic for incoming and outgoing message prominence is going to be identical, so move it to a module they can both include and use.
* Allow creation of multiple public bodies in one test.Louise Crow2013-09-16-2/+4
| | | | | Add some sequences to make sure that we don't get validation errors on unique fields.
* Convert specs to factories from fixtures.Louise Crow2013-09-16-52/+48
| | | | | | Conflicts: spec/integration/view_request_spec.rb
* Add prominence fields to outgoing message.Louise Crow2013-09-16-0/+6
|
* Add a test of incoming message hiding with PDF conversionLouise Crow2013-09-16-0/+59
|
* Don't make zip dir publicly accessible.Louise Crow2013-09-16-7/+0
| | | | We want to be able to authorise access to it.
* Clean up the test download dir after use.Louise Crow2013-09-16-0/+4
|
* Move some download methods to InfoRequest.Louise Crow2013-09-16-25/+41
| | | | | | Use send_file to send zips. Also adds 'all_can_view_all_correspondence?' - is this request completely cachable, or do we need to cache different versions for different levels of privilege?
* Add expectations for admin and requester.Louise Crow2013-09-16-5/+17
|
* Give incoming message a body attachmentLouise Crow2013-09-16-3/+5
| | | | By default, give an incoming message a body attachment.
* Restore the download for hidden requestsLouise Crow2013-09-16-30/+62
| | | | | | This was disabled for hidden requests as the download was by redirect, allowing people who have not been authenticated to conceivably access the download. We'll be moving to send_file instead, so can restore it.
* Fix problem with integration session reuse.Louise Crow2013-09-16-0/+7
| | | | | The third (and any subsequent) session created shares a session id with the second without this explicit reset.
* Make absence of htmltopdf converter more explicit.Louise Crow2013-09-16-47/+52
| | | | We're testing the code path where there is no converter here.
* Make external request download spec more specific.Louise Crow2013-09-16-4/+5
|
* Make sure that info_request gets assigned to the viewLouise Crow2013-09-16-2/+2
| | | | | | This should be handled by assign_variables_for_show_template. Otherwise, the make_request_summary_file method shouldn't depend on instance variables
* Move zip file creation to its own method.Louise Crow2013-09-16-16/+15
|
* Move display text generation to outgoing message.Louise Crow2013-09-16-5/+9
|
* Remove hidden incoming messages from correspondence.txtLouise Crow2013-09-16-46/+80
| | | | | | | Adds a spec for what we want to see - no message text in correspondence.txt, and no attachments. Refactors the simple_correspondence templates to make it clearer that these are doing the same job as the html.erb ones, for text.
* Split up translated messages.Louise Crow2013-09-16-7/+16
| | | | | | | | | Each part is a separate sentence, and we're going to reuse some of them in the text view. Conflicts: spec/integration/view_request_spec.rb
* Move a couple of complex conditionals to helper methods.Louise Crow2013-09-16-2/+11
| | | | We're about to reuse them for the text view.
* Remove unused param.Louise Crow2013-09-16-1/+1
| | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb
* Normalize method spacing.Louise Crow2013-09-16-0/+3
|
* Extract calculation of last update hashLouise Crow2013-09-16-2/+5
|
* Extract out code for making a request summary fileLouise Crow2013-09-16-50/+69
| | | | | | | | | | | | Render the show template within the current thread rather than making another request - we're going to need to use the current session in order to know what do include in the zip file, now that we have more fine-grained visibility of messages. Also, this will mean we can use this functionality in single threaded contexts, and test it more easily. Don't display profile photos as this would require another process, and hide other icons so we don't need to include them. Use render_to_string as a more standard way of rendering templates to a string for further manipulation.
* Extract the various info_request assignsLouise Crow2013-09-16-10/+16
| | | | | | So we can reuse them when rendering the show template to a file. Lots of the sidebar prep isn't going to be needed for that view, so make that optional in the template.
* Reorder assignsLouise Crow2013-09-16-12/+12
| | | | | Split into those that come from request params and those that come from the model
* Give incoming message factory a body text.Louise Crow2013-09-16-9/+21
| | | | Also, store an event for the incoming message.
* Rewrite download specLouise Crow2013-09-16-47/+76
| | | | | Make it an integration spec so we don't need to touch the internals so much.
* Allow an actual user to be passed to the login method.Louise Crow2013-09-16-1/+5
|
* Replace fixture-based spec with factory-based equivalent.Louise Crow2013-09-16-10/+6
|
* Use expectation for hidden responses more generally.Louise Crow2013-09-16-9/+9
|
* Fix request in spec for hidden attachments not being viewed.Louise Crow2013-09-16-2/+15
| | | | | Add another spec for the same behaviour when an incoming message is hidden.
* Add new code and specs for hiding attachments.Louise Crow2013-09-16-12/+139
|
* Refactor expectation into a methodLouise Crow2013-09-16-6/+8
| | | | Remove expectation of pdf contents - we're looking at the raw file.
* Use a real pdf file for foi_attachment factory.Louise Crow2013-09-16-2/+2
|
* Refactor prominence specs to use factories not fixtures.Louise Crow2013-09-16-117/+133
|
* Clarify specs.Louise Crow2013-09-16-5/+5
| | | | They refer to the case where the request itself is hidden.
* Handle the case of an empty string in the prominence_reason.Louise Crow2013-09-16-3/+3
| | | | | | | | | This will happen if the prominence has been changed in the admin interface but no reason has been filled in. Conflicts: app/views/request/_incoming_correspondence.html.erb
* Add a possible event type 'edit_incoming'.Louise Crow2013-09-16-1/+1
| | | | This will cover changes in prominence to incoming messages.
* Add the meat of the update action.Louise Crow2013-09-16-0/+89
|
* Link to the new incoming message edit form.Louise Crow2013-09-16-1/+6
| | | | From the request admin page.
* I don't think there's any need to refind incoming messages.Louise Crow2013-09-16-1/+1
| | | | The order is the same as the default association.
* Use new partial for incoming message admin boilerplate.Louise Crow2013-09-16-5/+1
|
* Add a simple edit action and templateLouise Crow2013-09-16-5/+61
|
* Make some simple factories for real objects.Louise Crow2013-09-16-0/+33
|
* Add factory_girl gemLouise Crow2013-09-16-0/+7
| | | | | Hopefully transitioning from fixtures to factories will mean faster running tests over time.
generated by cgit v1.2.3 (git 2.25.1) at 2025-10-03 14:49:03 +0000