| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
| |
Remove self.
Use unless instead of if !
Use . instead of :: for class methods
Remove explicit return
Use each instead of for
Use inline if
|
|
|
|
| |
https://github.com/bbatsov/ruby-style-guide#consistent-classes
|
|
|
|
| |
https://github.com/bbatsov/rails-style-guide#macro-style-methods
|
|
|
|
|
| |
Really difficult to figure out what’s going on when a callback is
buried halfway between a load of methods
|
|
|
|
| |
Picks these up in `rake notes` and adds semantic meaning
|
|
|
|
|
| |
Should have been run after related migrations.
Could automate this to always run after migrations.
|
|
|
|
| |
This is the most rudimentary possible way to give them access to the batch request urls, pending #1239
|
|
|
|
|
| |
Re-annotate models. Index InfoRequestBatches by user - we'll display the
batches for a user when they view their own requests.
|
|
|
|
|
|
|
| |
It doesn't make logical sense that they would. However I am preserving
the ability to make batch requests as a separate thing from not having a
daily limit - I think batch sending requires a (perhaps marginally)
bigger level of trust.
|
|
|
|
| |
These are regenerated with "bundle exec annotate"
|
|
|
|
| |
A super user will be able to see all hidden things, not just requests.
|
| |
|
|
|
|
| |
translation gets picked up by rake gettext:find. Add a bit more explanation.
|
|\ |
|
| | |
|
| | |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
Gemfile
Gemfile.lock
app/controllers/general_controller.rb
app/controllers/track_controller.rb
app/models/outgoing_message.rb
app/models/public_body.rb
app/models/user.rb
app/views/general/frontpage.rhtml
config/environment.rb
config/initializers/inflections.rb
config/initializers/mime_types.rb
db/migrate/094_remove_old_tags_foreign_key.rb
lib/timezone_fixes.rb
spec/models/request_mailer_spec.rb
spec/views/request/list.rhtml_spec.rb
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
Gemfile.lock
app/controllers/general_controller.rb
app/controllers/public_body_controller.rb
spec/controllers/public_body_controller_spec.rb
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ / |
|
| | |
| | |
| | |
| | | |
functions calling gsub on the result. SafeBuffer won't work with gsub until Rails 3.2 https://github.com/rails/rails/commit/b4a6e2f8442ceda118367f9a61c38af754be1cbf
|
| | | |
|
| |/
|/| |
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
variable, but that commonlib/rblib/config.rb does not allow nil defaults, replace nil value clause (which can never be reached) with blank value condition(blank now returned by default by lib/configuation.rb)
|
| |
|
| |
|
|
|
|
| |
Closes #30.
|
| |
|
|
|
|
| |
Otherwise we issue PURGEs every time, for example, we send out email alerts.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Includes a couple of additional fixes:
* Remember to HTML-quote things that could come from users
* Fix form post action for editing users
|
|
|
|
| |
wombleton:feature/440_sparkly_admin_css)
|
|
|
|
| |
Next step: making it asynchronous, e.g. with a queue of things to purge via a cron job.
|
|
|
|
| |
Closes #415.
|
|
|
|
|
|
| |
Don't change logged-in user from an admin when visiting a auto-login URL.
Closes #306.
|
|
|
|
|
| |
Include information about what the per-day limit is, and when the
user can next make a request. Fixes #412.
|
|
|
|
|
|
|
|
| |
When a user account has been suspended, we write (Banned) after their
user name. But sometimes we need to suspend accounts temporarily,
such as pending the result of a discussion, and it is misleading
to write (Banned) in such cases; so let’s change it to (Account
suspended) instead.
|
|
|
|
|
|
| |
Add the capability to specify a limit to the number of requests a
user can make per day, which can be turned off for specific users
in the admin interface.
|
| |
|
|\
| |
| |
| |
| |
| | |
Conflicts:
config/general.yml-example
spec/models/track_mailer_spec.rb
|
| |
| |
| |
| |
| | |
The User.should_be_emailed? method needs to be public. It should also
be tested.
|
| |
| |
| |
| |
| | |
Add tests for the User.record_bounce_for_email method and (not coincidentally)
make it actually work.
|
| |
| |
| |
| | |
are storing the entire bounce email in there now.
|