| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basic handling that is the same as for other process errors - just write to
stderr. Add TODO for allowing the calling code to specify an error stream
to allow other handling. In different circumstances, the calling code might want
to raise an exception, write to the log, or do something else. At the
moment this code assumes a cron context and writes to stderr, which will
cause an email to be sent from the cron process, but that's not always the
context the calling code is being run in. So we may be missing errors that are, for
example, being written to stderr during the request cycle.
In fact, this code may be called from the same
place with different contexts (i.e. as part of a cron reindexing task and
in the request cycle), so at the moment some substantial refactoring of the
calling code would be required to make sure calls to this code handle errors
appropriately for each context.
|
|
|
|
| |
To make it easier to find them in other output.
|
| |
|
|
|
|
| |
Clarify grouping of command and arguments with quotes.
|
|
|
|
|
| |
There may be cases where the input is binary but the output is encoded
text.
|
|
|
|
| |
Document :timeout as a possible option key.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
Rakefile
app/models/contact_mailer.rb
spec/models/contact_mailer_spec.rb
|
| | |
|
|/ |
|
|
|
|
| |
the binary_output flag if set.
|
| |
|
|
|
|
| |
`uudecode` in Ubuntu 11.10)
|
|
|
|
|
| |
The behaviour of elinks is locale-dependent. This patch forces LANG=C
which makes the behaviour consistent across platforms.
|
|
|
|
|
|
|
|
|
|
| |
The trouble with `which command` is twofold:
- It spawns a whole shell just to find out the path to a binary, every time;
- The results are environment-dependent, since they depend on $PATH. It would
be better to specify the search path in the configuration file where everything
else is specified rather than in the environment.
This commit replaces it with the new mechanism from AlaveteliExternalCommand.
|
|
|
|
|
|
| |
Look for external commands in a config-defined path (defaulting
to /usr/bin:/usr/local/bin), rather than requiring the path to be
hard-coded or the caller to resolve it.
|
|
|