aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers
Commit message (Collapse)AuthorAgeLines
* Fix #372Robin Houston2012-01-26-10/+26
|
* Correct test titleRobin Houston2012-01-25-1/+1
|
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-25-19/+79
|\ | | | | | | | | Conflicts: app/controllers/request_controller.rb
| * More better test isolationRobin Houston2012-01-24-0/+1
| | | | | | | | | | Towards #361. Fixes: spec/models/xapian_spec.rb spec/controllers/user_controller_spec.rb
| * Improve test isolationRobin Houston2012-01-24-0/+2
| | | | | | | | | | Towards #361. Fixes: spec/models/xapian_spec.rb spec/controllers/general_controller_spec.rb
| * Fix sporadic test failureRobin Houston2012-01-24-1/+6
| | | | | | | | Another contribution to #361.
| * Fix a bunch of order-dependent failuresRobin Houston2012-01-24-1/+1
| | | | | | | | This fixes a lot of the failures in #361.
| * Add missing fixturesRobin Houston2012-01-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this addition, the "shows a user" test would fail unless run in a context where the public body fixtures had already been loaded, with an error like this: ActionView::TemplateError in 'AdminUserController when administering users shows a user' undefined method `name' for nil:NilClass On line #14 of app/views/admin_request/_some_requests.rhtml 11: <% for info_request in info_requests %> 12: <tr class="<%= cycle('odd', 'even') %>"> 13: <td><%= request_both_links(info_request) %></td> 14: <td><%= public_body_both_links(info_request.public_body) %></td> 15: <td><%= user_both_links(info_request.user) %></td> 16: <% for column in InfoRequest.content_columns.map { |c| c.name } - [ "title", "url_title" ] %> 17: <td><%=h info_request.send(column) %></td>
| * Remove assumptionRobin Houston2012-01-20-6/+5
| | | | | | | | | | | | | | I feel uncomfortable about the assumption that FastGettext.default_available_locales is always equal to I18n.available_locales. Even if that’s true now, it might not always be -- and if a bug causes them to become erroneously different, the previous code would have masked that.
| * Clear routing filters while tests are runningRobin Houston2012-01-20-0/+10
| | | | | | | | | | | | This fixes a test failure that would show up when running this spec in isolation -- but not necessarily when running all tests, depending on the order they run in.
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-10/+49
| |\
| | * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-1/+11
| | |\
| | * | Make sure the FakeWeb registry is kept cleanRobin Houston2012-01-20-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To be fair this change does not seem to make any tests pass that didn’t pass before, but (based on my limited understanding) it seems like a good idea. It also conforms to how FakeWeb is used in application_controller_spec.rb.
| | * | Be sure to restore RoutingFiltersRobin Houston2012-01-20-10/+42
| | | | | | | | | | | | | | | | | | | | | | | | There were some order-dependent test failures that turned out to be caused by the fact that the RoutingFilters were cleared and not subsequently restored, by some tests.
| * | | Improved test isolationRobin Houston2012-01-20-0/+4
| | |/ | |/| | | | | | | | | | The test “AdminRequestController when administering requests shows a public body” would fail when this spec is run on its own twice in succession.
* | | Return a 404 for missing user profile pictures. Fixes #363Seb Bacon2012-01-24-0/+7
| | |
* | | Ensure short cache keys for interlock. Fixes #362Seb Bacon2012-01-24-0/+5
| | |
* | | Bug: we are causing a 500 when trying to raise 404 because the arguments to ↵Seb Bacon2012-01-24-0/+9
|/ / | | | | | | the exception constructor are wrong.
* / Don't allow users to page beyond a certain number of results (because in ↵Seb Bacon2012-01-20-1/+11
|/ | | | large databases, the sorting of such large batches causes an extreme slowdown).
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-19-1/+29
|\
| * Return a 404 for broken attachment urls. Fixes #351.Seb Bacon2012-01-18-0/+10
| |
| * Fix more test breakageSeb Bacon2012-01-18-1/+7
| |
| * Catch timeouts and other extra errors when connection to 3rd party websites ↵Seb Bacon2012-01-18-1/+8
| | | | | | | | fails.
| * Ensure request typeahead search is tested properly (and fix a validation error).Seb Bacon2012-01-18-0/+2
| |
| * Fix paging bug for type ahead search. This wasn't caught because the spec ↵Seb Bacon2012-01-18-0/+3
| | | | | | | | didn't call "integrate_views", so the rendering part was mocked by RSpec instead of executed.
* | Don't choke on very long filenames when caching attachments. Fixes #349.Seb Bacon2012-01-19-0/+9
|/
* Test belonging to commit a39f71ee21739eb754688f185c59c3a7f209aaaSeb Bacon2012-01-17-3/+3
|
* Test fix that belongs to e82ca928a140400f8446dba85014a0c9059e789bSeb Bacon2012-01-17-1/+1
|
* Actually do a proper ORed and partial match query, rather than fix parsing ↵Seb Bacon2012-01-17-2/+12
| | | | errors ad hoc as I find them that result from the workaround code. Fixes #328 (for good, I hope).
* Fail silently if third party services are broken or unavailable. Fixes #354.Seb Bacon2012-01-17-6/+31
|
* Fix bug introduced in cec2c545e0a10e0641c4ee67839c88d872b394b8, related to ↵Seb Bacon2012-01-13-12/+34
| | | | issue #343.
* Show internal_review (and some other) items in the "unresolved" list. Fixes ↵Seb Bacon2012-01-13-0/+10
| | | | #344.
* Ensure we show "all requests" in order that they were last updated. FIxes #343.Seb Bacon2012-01-13-3/+6
|
* Fix further special character searches as per issue #328Seb Bacon2012-01-13-1/+2
|
* Further fix for issue #328.Seb Bacon2012-01-12-2/+2
|
* Further fix for issue #328.Seb Bacon2012-01-12-2/+15
|
* Accounts using expired PostRedirects were still causing 500 errors. Fixes ↵Seb Bacon2012-01-12-2/+3
| | | | #334 (again)
* Fix typeahead search specs to match recent API changeSeb Bacon2012-01-11-5/+5
|
* Fix problem with typeahead searches containing " - " characters and similar. ↵Seb Bacon2012-01-11-1/+17
| | | | Closes #328
* Don't give an error to users with an invalid postredirect token. Closes #334.Seb Bacon2012-01-11-0/+13
|
* Don't give error when viewing HTML versions. Fixes issue #321Seb Bacon2012-01-08-0/+9
|
* Merge branch 'fixing-xapian-reindexing' into release/0.5Seb Bacon2012-01-06-2/+2
|\
| * Make test less brittleSeb Bacon2012-01-06-2/+2
| |
* | Fix zip-attachment functionalitySeb Bacon2012-01-06-3/+3
|/
* Reintroduce a "my requests" link. Fixes #289.Seb Bacon2012-01-02-0/+10
|
* Ensure we only parse emails when needed by referring to a new last_parsed ↵Seb Bacon2011-12-21-2/+4
| | | | field on incoming_messages. Currently mails are always parsed just-in-time, but could be parsed as a queue in the future.
* Merge branch 'develop' into cache-foi-attachments-sebSeb Bacon2011-12-21-10/+8
|\ | | | | | | | | Conflicts: app/controllers/request_controller.rb
| * Don't do wildcard searches for partial matches in type ahead searches. ↵Seb Bacon2011-12-21-10/+8
| | | | | | | | Fixes #310.
* | Further improvements to attachment cachingSeb Bacon2011-12-13-4/+4
| |
* | WIP on caching attachmentsSeb Bacon2011-12-12-5/+65
|/
generated by cgit v1.2.3 (git 2.25.1) at 2025-10-04 07:35:03 +0000