1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
|
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
describe AdminPublicBodyController, "when administering public bodies" do
integrate_views
before do
@old_filters = ActionController::Routing::Routes.filters
ActionController::Routing::Routes.filters = RoutingFilter::Chain.new
end
after do
ActionController::Routing::Routes.filters = @old_filters
end
it "shows the index page" do
get :index
end
it "searches for 'humpa'" do
get :index, :query => "humpa"
assigns[:public_bodies].should == [ public_bodies(:humpadink_public_body) ]
end
it "shows a public body" do
get :show, :id => 2
end
it "creates a new public body" do
n = PublicBody.count
post :create, { :public_body => { :name => "New Quango", :short_name => "", :tag_string => "blah", :request_email => 'newquango@localhost', :last_edit_comment => 'From test code' } }
PublicBody.count.should == n + 1
end
it "edits a public body" do
get :edit, :id => 2
end
it "saves edits to a public body" do
public_bodies(:humpadink_public_body).name.should == "Department for Humpadinking"
post :update, { :id => 3, :public_body => { :name => "Renamed", :short_name => "", :tag_string => "some tags", :request_email => 'edited@localhost', :last_edit_comment => 'From test code' } }
response.flash[:notice].should include('successful')
pb = PublicBody.find(public_bodies(:humpadink_public_body).id)
pb.name.should == "Renamed"
end
it "does not destroy a public body that has associated requests" do
id = public_bodies(:humpadink_public_body).id
n = PublicBody.count
post :destroy, { :id => id }
response.should redirect_to(:controller=>'admin_public_body', :action=>'show', :id => id)
PublicBody.count.should == n
end
it "destroys a public body" do
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
response.should redirect_to(:controller=>'admin_public_body', :action=>'list')
PublicBody.count.should == n - 1
end
it "sets a using_admin flag" do
get :show, :id => 2
session[:using_admin].should == 1
end
it "mass assigns tags" do
n = PublicBody.count
post :mass_tag_add, { :new_tag => "department", :table_name => "substring" }
response.flash[:notice].should == "Added tag to table of bodies."
response.should redirect_to(:action=>'list')
PublicBody.find_by_tag("department").count.should == n
end
describe 'import_csv' do
describe 'when handling a GET request' do
it 'should get the page successfully' do
get :import_csv
response.should be_success
end
end
describe 'when handling a POST request' do
before do
PublicBody.stub!(:import_csv).and_return([[],[]])
@file_object = mock("a file upload", :read => 'some contents',
:original_filename => 'contents.txt')
end
it 'should handle a nil csv file param' do
post :import_csv, { :commit => 'Dry run' }
response.should be_success
end
describe 'if there is a csv file param' do
it 'should try to get the contents and original name of a csv file param' do
@file_object.should_receive(:read).and_return('some contents')
post :import_csv, { :csv_file => @file_object,
:commit => 'Dry run'}
end
it 'should assign the original filename to the view' do
post :import_csv, { :csv_file => @file_object,
:commit => 'Dry run'}
assigns[:original_csv_file].should == 'contents.txt'
end
end
describe 'if there is no csv file param, but there are temporary_csv_file and
original_csv_file params' do
it 'should try and get the file contents from a temporary file whose name
is passed as a param' do
@controller.should_receive(:retrieve_csv_data).with('csv_upload-2046-12-31-394')
post :import_csv, { :temporary_csv_file => 'csv_upload-2046-12-31-394',
:original_csv_file => 'original_contents.txt',
:commit => 'Dry run'}
end
it 'should raise an error on an invalid temp file name' do
params = { :temporary_csv_file => 'bad_name',
:original_csv_file => 'original_contents.txt',
:commit => 'Dry run'}
expected_error = "Invalid filename in upload_csv: bad_name"
lambda{ post :import_csv, params }.should raise_error(expected_error)
end
it 'should raise an error if the temp file does not exist' do
temp_name = "csv_upload-20461231-394"
params = { :temporary_csv_file => temp_name,
:original_csv_file => 'original_contents.txt',
:commit => 'Dry run'}
expected_error = "Missing file in upload_csv: csv_upload-20461231-394"
lambda{ post :import_csv, params }.should raise_error(expected_error)
end
it 'should assign the temporary filename to the view' do
post :import_csv, { :csv_file => @file_object,
:commit => 'Dry run'}
temporary_filename = assigns[:temporary_csv_file]
temporary_filename.should match(/csv_upload-#{Time.now.strftime("%Y%m%d")}-\d{1,5}/)
end
end
end
end
end
describe AdminPublicBodyController, "when administering public bodies and paying attention to authentication" do
integrate_views
before do
config = MySociety::Config.load_default()
config['SKIP_ADMIN_AUTH'] = false
basic_auth_login @request
end
after do
config = MySociety::Config.load_default()
config['SKIP_ADMIN_AUTH'] = true
end
def setup_emergency_credentials(username, password)
config = MySociety::Config.load_default()
config['SKIP_ADMIN_AUTH'] = false
config['ADMIN_USERNAME'] = username
config['ADMIN_PASSWORD'] = password
@request.env["HTTP_AUTHORIZATION"] = ""
end
it "disallows non-authenticated users to do anything" do
@request.env["HTTP_AUTHORIZATION"] = ""
n = PublicBody.count
post :destroy, { :id => 3 }
response.should redirect_to(:controller=>'user', :action=>'signin', :token=>PostRedirect.get_last_post_redirect.token)
PublicBody.count.should == n
session[:using_admin].should == nil
end
it "skips admin authorisation when SKIP_ADMIN_AUTH set" do
config = MySociety::Config.load_default()
config['SKIP_ADMIN_AUTH'] = true
@request.env["HTTP_AUTHORIZATION"] = ""
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
PublicBody.count.should == n - 1
session[:using_admin].should == 1
end
it "doesn't let people with bad emergency account credentials log in" do
setup_emergency_credentials('biz', 'fuz')
n = PublicBody.count
basic_auth_login(@request, "baduser", "badpassword")
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
response.should redirect_to(:controller=>'user', :action=>'signin', :token=>PostRedirect.get_last_post_redirect.token)
PublicBody.count.should == n
session[:using_admin].should == nil
end
it "allows people with good emergency account credentials log in using HTTP Basic Auth" do
setup_emergency_credentials('biz', 'fuz')
n = PublicBody.count
basic_auth_login(@request, "biz", "fuz")
post :show, { :id => public_bodies(:humpadink_public_body).id, :emergency => 1}
session[:using_admin].should == 1
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
session[:using_admin].should == 1
PublicBody.count.should == n - 1
end
it "allows superusers to do stuff" do
session[:user_id] = users(:admin_user).id
@request.env["HTTP_AUTHORIZATION"] = ""
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
PublicBody.count.should == n - 1
session[:using_admin].should == 1
end
it "doesn't allow non-superusers to do stuff" do
session[:user_id] = users(:robin_user).id
@request.env["HTTP_AUTHORIZATION"] = ""
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
response.should redirect_to(:controller=>'user', :action=>'signin', :token=>PostRedirect.get_last_post_redirect.token)
PublicBody.count.should == n
session[:using_admin].should == nil
end
describe 'when asked for the admin current user' do
it 'returns the emergency account name for someone who logged in with the emergency account' do
setup_emergency_credentials('biz', 'fuz')
basic_auth_login(@request, "biz", "fuz")
post :show, { :id => public_bodies(:humpadink_public_body).id, :emergency => 1 }
controller.send(:admin_current_user).should == 'biz'
end
it 'returns the current user url_name for a superuser' do
session[:user_id] = users(:admin_user).id
@request.env["HTTP_AUTHORIZATION"] = ""
post :show, { :id => public_bodies(:humpadink_public_body).id }
controller.send(:admin_current_user).should == users(:admin_user).url_name
end
it 'returns the REMOTE_USER value from the request environment when skipping admin auth' do
config = MySociety::Config.load_default()
config['SKIP_ADMIN_AUTH'] = true
@request.env["HTTP_AUTHORIZATION"] = ""
@request.env["REMOTE_USER"] = "i_am_admin"
post :show, { :id => public_bodies(:humpadink_public_body).id }
controller.send(:admin_current_user).should == "i_am_admin"
end
end
end
describe AdminPublicBodyController, "when administering public bodies with i18n" do
integrate_views
it "shows the index page" do
get :index
end
it "searches for 'humpa'" do
get :index, {:query => "humpa", :locale => "es"}
assigns[:public_bodies].should == [ public_bodies(:humpadink_public_body) ]
end
it "shows a public body" do
get :show, {:id => 2, :locale => "es" }
end
it "edits a public body" do
get :edit, {:id => 3, :locale => :en}
# When editing a body, the controller returns all available translations
assigns[:public_body].translation("es").name.should == 'El Department for Humpadinking'
assigns[:public_body].name.should == 'Department for Humpadinking'
response.should render_template('edit')
end
it "saves edits to a public body" do
PublicBody.with_locale(:es) do
pb = PublicBody.find(id=3)
pb.name.should == "El Department for Humpadinking"
post :update, {
:id => 3,
:public_body => {
:name => "Department for Humpadinking",
:short_name => "",
:tag_string => "some tags",
:request_email => 'edited@localhost',
:last_edit_comment => 'From test code',
:translated_versions => {
3 => {:locale => "es", :name => "Renamed",:short_name => "", :request_email => 'edited@localhost'}
}
}
}
response.flash[:notice].should include('successful')
end
pb = PublicBody.find(public_bodies(:humpadink_public_body).id)
PublicBody.with_locale(:es) do
pb.name.should == "Renamed"
end
PublicBody.with_locale(:en) do
pb.name.should == "Department for Humpadinking"
end
end
it "destroy a public body" do
n = PublicBody.count
post :destroy, { :id => public_bodies(:forlorn_public_body).id }
PublicBody.count.should == n - 1
end
end
describe AdminPublicBodyController, "when creating public bodies with i18n" do
integrate_views
before do
@old_filters = ActionController::Routing::Routes.filters
ActionController::Routing::Routes.filters = RoutingFilter::Chain.new
end
after do
ActionController::Routing::Routes.filters = @old_filters
end
it "creates a new public body in one locale" do
n = PublicBody.count
post :create, { :public_body => { :name => "New Quango", :short_name => "", :tag_string => "blah", :request_email => 'newquango@localhost', :last_edit_comment => 'From test code' } }
PublicBody.count.should == n + 1
body = PublicBody.find_by_name("New Quango")
response.should redirect_to(:controller=>'admin_public_body', :action=>'show', :id=>body.id)
end
it "creates a new public body with multiple locales" do
n = PublicBody.count
post :create, {
:public_body => {
:name => "New Quango", :short_name => "", :tag_string => "blah", :request_email => 'newquango@localhost', :last_edit_comment => 'From test code',
:translated_versions => [{ :locale => "es", :name => "Mi Nuevo Quango", :short_name => "", :request_email => 'newquango@localhost' }]
}
}
PublicBody.count.should == n + 1
body = PublicBody.find_by_name("New Quango")
body.translations.map {|t| t.locale.to_s}.sort.should == ["en", "es"]
PublicBody.with_locale(:en) do
body.name.should == "New Quango"
body.url_name.should == "new_quango"
body.first_letter.should == "N"
end
PublicBody.with_locale(:es) do
body.name.should == "Mi Nuevo Quango"
body.url_name.should == "mi_nuevo_quango"
body.first_letter.should == "M"
end
response.should redirect_to(:controller=>'admin_public_body', :action=>'show', :id=>body.id)
end
end
|