aboutsummaryrefslogtreecommitdiffstats
path: root/app/models/info_request.rb
diff options
context:
space:
mode:
authorMatthew Landauer <matthew@openaustralia.org>2013-03-01 14:54:09 +1100
committerMatthew Landauer <matthew@openaustralia.org>2013-03-02 14:49:13 +1100
commit66279a9373226f49d0c47ab651f61deb2aebf1a7 (patch)
tree5b8059611e60e5dcb18f4035ef8e7bd76d343de7 /app/models/info_request.rb
parentd88b79d1aa24a78ed95255a37a0403d7e3c0117e (diff)
Simplify logic in method
Diffstat (limited to 'app/models/info_request.rb')
-rw-r--r--app/models/info_request.rb9
1 files changed, 2 insertions, 7 deletions
diff --git a/app/models/info_request.rb b/app/models/info_request.rb
index f7391a60a..e0ade0eb6 100644
--- a/app/models/info_request.rb
+++ b/app/models/info_request.rb
@@ -972,13 +972,8 @@ public
end
def is_old_unclassified?
- return false if is_external?
- return false if !awaiting_description
- return false if url_title == 'holding_pen'
- last_response_event = get_last_response_event
- return false unless last_response_event
- return false if last_response_event.created_at >= Time.now - OLD_AGE_IN_DAYS
- return true
+ !is_external? && awaiting_description && url_title != 'holding_pen' && get_last_response_event &&
+ Time.now > get_last_response_event.created_at + OLD_AGE_IN_DAYS
end
# List of incoming messages to followup, by unique email