Commit message (Collapse) | Author | Age | Lines | ||
---|---|---|---|---|---|
... | |||||
* | | | | Don't error on a request to followup an external request. | Louise Crow | 2012-08-23 | -0/+26 | |
| | | | | | | | | | | | | | | | | Partial solution to #562. | ||||
* | | | | Handle the case where someone wants to add an annotation to a successful ↵ | Louise Crow | 2012-08-23 | -2/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | external request. Fixes #563. | ||||
* | | | | Merge branch 'release/0.6.3' into develop | Louise Crow | 2012-08-22 | -309/+4654 | |
|\ \ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Conflicts: app/controllers/admin_public_body_controller.rb app/views/admin_public_body/import_csv.rhtml spec/controllers/admin_public_body_controller_spec.rb spec/models/info_request_spec.rb | ||||
| * | | | Revert inadvertently committed development environment changes.release/0.6.3 | Louise Crow | 2012-08-22 | -3/+3 | |
| | | | | |||||
| * | | | Rework the temporary storing of a csv file of public body info between a dry ↵ | Louise Crow | 2012-08-20 | -49/+175 | |
| | | | | | | | | | | | | | | | | run and real load. Use a temp file, not the session for the data. Also fixes #503. | ||||
| * | | | Add p tags to make blockquote html valid. | Louise Crow | 2012-08-20 | -15/+16 | |
| | | | | |||||
| * | | | Rollback change to activerecord session store - whilst activerecord store ↵ | Louise Crow | 2012-08-15 | -2/+18 | |
| | | | | | | | | | | | | | | | | has some advantages (notably avoiding permanent versus transient session hijack possibilities), I think it needs some more work/testing (we'd need to have good code for cleaning out stale activerecord sessions periodically - with activerecord store this is now our responsibility). We'd also need to reset the session key to kill all in progress sessions to prevent errors as rails tries to store long cookie keys in the limited key field of the activerecord store. For this release, it'll be more straightforward to fix the csv_upload file issue #526 in a more localized way. | ||||
| * | | | Update commit list url to reflect the fact that develop, not master is now ↵ | Louise Crow | 2012-08-14 | -1/+1 | |
| | | | | | | | | | | | | | | | | the default branch. | ||||
| * | | | Add warning about regex censor rules. | Louise Crow | 2012-08-14 | -1/+3 | |
| | | | | | | | | | | | | | | | | Fix spec to accommodate validation of text presence. | ||||
| * | | | Validate presence of text to replace in censor rules. | Louise Crow | 2012-08-14 | -0/+7 | |
| | | | | |||||
| * | | | Add basic validation for regexp censor rules that a valid regexp can be ↵ | Louise Crow | 2012-08-14 | -6/+53 | |
| | | | | | | | | | | | | | | | | created with the text of the rule. | ||||
| * | | | Make global validation work correctly for regex censor rules. | Louise Crow | 2012-08-14 | -3/+10 | |
| | | | | |||||
| * | | | Whether a rule is a regex rule should not affect the redirect that happens ↵ | Louise Crow | 2012-08-14 | -2/+0 | |
| | | | | | | | | | | | | | | | | after you create it. | ||||
| * | | | Apply global and public body censor rules to binary files. | Louise Crow | 2012-08-14 | -32/+70 | |
| | | | | |||||
| * | | | Add case of a regex censor rule to test of binary masking. | Louise Crow | 2012-08-14 | -13/+20 | |
| | | | | |||||
| * | | | Handle regexp rules when running censor rules on binary files. | Louise Crow | 2012-08-14 | -11/+20 | |
| | | | | |||||
| * | | | Add association between public bodies and censor rules, have info_request ↵ | Louise Crow | 2012-08-14 | -1/+10 | |
| | | | | | | | | | | | | | | | | apply rules from its public body. | ||||
| * | | | Add concept of global censor rules as orthogonal to regex censor rules. ↵ | Louise Crow | 2012-08-14 | -164/+270 | |
| | | | | | | | | | | | | | | | | Apply global rules to every request, not regex rules. | ||||
| * | | | Add before and after methods to isolate any effect these tests have on locale. | Louise Crow | 2012-08-13 | -2/+12 | |
| | | | | |||||
| * | | | Latest translation files from Transifex - with new msgids, and in Transifex ↵ | Louise Crow | 2012-08-09 | -64/+256 | |
| | | | | | | | | | | | | | | | | format. | ||||
| * | | | Latest translations from Transifex. | Louise Crow | 2012-08-09 | -93/+3845 | |
| | | | | |||||
| * | | | Set api_key in before_save rather than after_initialize (to avoid errors ↵ | Seb Bacon | 2012-07-19 | -2/+4 | |
| | | | | | | | | | | | | | | | | when uploading via CSV) | ||||
| * | | | Use ActiveRecord to store sessions, rather than Cookies. Fixes #526. | Seb Bacon | 2012-07-19 | -1/+17 | |
| | | | | |||||
| * | | | Fix bug preventing CSV upload. Fixes #525 (needs tests!) | Seb Bacon | 2012-07-19 | -7/+7 | |
| | | | | |||||
| * | | | Description for 0.6.3 | Seb Bacon | 2012-07-17 | -0/+21 | |
| | | | | |||||
* | | | | With reference to issue #560, generate better text in the case of an ↵ | Louise Crow | 2012-08-22 | -6/+7 | |
| | | | | | | | | | | | | | | | | anonymous external user when being viewed by either an admin or non admin. | ||||
* | | | | Fix typo. | Louise Crow | 2012-08-22 | -5/+5 | |
| | | | | |||||
* | | | | With reference to #561, display "[An anonymous user]" rather than an empty ↵ | Louise Crow | 2012-08-22 | -2/+2 | |
| | | | | | | | | | | | | | | | | string for external requests with no external user name. | ||||
* | | | | Merge branch 'develop' of github.com:sebbacon/alaveteli into develop | Louise Crow | 2012-08-22 | -0/+16 | |
|\ \ \ \ | |||||
| * | | | | Correct constraint on external requests | Robin Houston | 2012-08-22 | -0/+16 | |
| | | | | | |||||
* | | | | | Use user_name to supply the user name for an internal or external request in ↵ | Louise Crow | 2012-08-22 | -38/+48 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the simple correspondence template used when a full request zip is downloaded. Fixes #561. | ||||
* | | | | | Method spacing. | Louise Crow | 2012-08-22 | -0/+19 | |
|/ / / / | |||||
* | | | | Fix admin links in the case where an external request is viewed by an admin ↵ | Louise Crow | 2012-08-22 | -21/+33 | |
| | | | | | | | | | | | | | | | | user. | ||||
* | | | | Don't send comment alerts for external requests. | Louise Crow | 2012-08-22 | -3/+14 | |
| | | | | |||||
* | | | | Re-enable testing of comment links in emails. | Louise Crow | 2012-08-22 | -7/+2 | |
| | | | | |||||
* | | | | Clearer formatting of global fixtures list. | Louise Crow | 2012-08-22 | -7/+21 | |
| | | | | |||||
* | | | | Fix comment typo. | Louise Crow | 2012-08-22 | -2/+2 | |
| | | | | |||||
* | | | | Allow external requests to be hidden from the admin interface. | Louise Crow | 2012-08-22 | -6/+60 | |
| | | | | |||||
* | | | | Use user_name instead of user.name to handle external requests. | Louise Crow | 2012-08-22 | -4/+7 | |
| | | | | |||||
* | | | | Merge branch 'develop' of github.com:sebbacon/alaveteli into develop | Louise Crow | 2012-08-21 | -2/+5 | |
|\ \ \ \ | |||||
| * \ \ \ | Merge branch 'develop' of github.com:sebbacon/alaveteli into develop | Robin Houston | 2012-08-21 | -0/+4 | |
| |\ \ \ \ | |||||
| * | | | | | Email admins about external requests too | Robin Houston | 2012-08-21 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If someone reports an external request as needing administrator attention, we should email the administrators about it. Thanks for spotting this, @crowbot. | ||||
* | | | | | | Don't pass a page param of less than one through to Xapian, treat it as a ↵ | Louise Crow | 2012-08-21 | -4/+14 | |
| |/ / / / |/| | | | | | | | | | | | | | | param of 1. Fixes #557. | ||||
* | | | | | Merge branch 'develop' of github.com:sebbacon/alaveteli into develop | Louise Crow | 2012-08-20 | -38/+50 | |
|\| | | | | |||||
| * | | | | Fail with NotFound if request slug doesn't exist | Robin Houston | 2012-08-20 | -26/+37 | |
| | | | | | | | | | | | | | | | | | | | | Closes #554. | ||||
| * | | | | ECONNRESET is another error we might get | Robin Houston | 2012-08-20 | -2/+2 | |
| | | | | | |||||
| * | | | | Do not send email for external requests | Robin Houston | 2012-08-20 | -3/+3 | |
| | | | | | |||||
| * | | | | Fix another test | Robin Houston | 2012-08-20 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Is there actually any point in tests of this sort? It is not testing that anything works as intended, only that a particular SQL string is passed to the database -- and surely the only way that string could have been discovered for test purposes was essentially to copy it from the code under test. It seems to me that the only real function of a test of this sort is to make it more difficult to modify the code under test. | ||||
| * | | | | Fix tests | Robin Houston | 2012-08-20 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make the InfoRequest#is_old_unclassified? method a little more conservative, by returning false only is the is_external? method returns true. This makes it subtly inconsistent with InfoRequest.find_old_unclassified, but it is better I think to be subtly inconsistent than to risk breaking things that used to work. | ||||
| * | | | | External requests ought not to be considered old_unclassified | Robin Houston | 2012-08-20 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | We certainly do not want to send reminder emails for such requests, for example, since we do not know the email address to send them to. |