| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
| |
PublicBodyCategory and PublicBodyHeading
|
|
|
|
| |
Picks these up in `rake notes` and adds semantic meaning
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extracts the attachment processing from FoiAttachment#body_to_html
AttachmentToHTML contains adapters which convert
- text/plain
- application/pdf
- application/rtf
Results are returned as an AttachmentHTML::HTML instance which contains
the raw HTML and other metadata about the conversion.
|
|
|
|
|
|
|
| |
Just expecting the parsed file to include the expected one would mean
success in the case where nothing has been folded. Tighten up the
expectation, and add quoting placeholders to expected files that didn't
have them.
|
|
|
|
|
| |
This requires us to clear the I18n.fallbacks when changing the
I18n.default_locale, otherwise the old default locale remains there.
|
|
|
|
|
|
|
|
|
|
| |
These are essentially required in exactly the same way as before, but
from lib/themes rather than vendor/plugins. This is the simplest
possible change in order make the themes work outside vendor/plugins,
I think, but it's not necessarily ideal. It would be worth considering
whether these should be changed to Rails engines, as described here:
http://guides.rubyonrails.org/engines.html
|
|
|
|
|
| |
This includes making making sure that xapiandbs directory is moved
with this version of the code.
|
| |
|
| |
|
|
|
|
|
|
| |
Although the I18n library has an I18n.with_locale helper, there's
no equivalent for I18n.default_locale. This method will make a
couple of our tests clearer and less brittle.
|
|
|
|
|
|
|
|
| |
The WDTK volunteers pointed out that it's not fair to include
hidden requests in the denominator, since they're typically hidden
for a good reason (e.g. being vexatious, spam, etc.), and we have
no information about those that are awaiting_description (i.e.
unclassified) so they should be excluded as well.
|
|
|
|
|
|
|
|
|
|
| |
In a subsequent commit, we will want to wrap an additional section
of code with the addition and removal of a hook that creates a
duplicate xapian job, so it's useful for this to be factored out.
This commit introduces a 'with_duplicate_xapian_job_creation'
method that can be passed a block which will be run with the forced
duplicate xapian job creation.
|
| |
|
|
|
|
| |
outside initialization e.g. in tests.
|
| |
|
|
|
|
| |
the URL) off by default in model, controller, and helper tests. This means we can supply the locale as a param. Turn it on specifically for a couple of controller tests that test routing, and change other url localization tests into integration tests.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
doing this but isn't for controller tests
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
Gemfile.lock
Rakefile
app/controllers/request_controller.rb
lib/tasks/rspec.rake
spec/controllers/services_controller_spec.rb
spec/spec_helper.rb
spec/views/request/_after_actions.rhtml_spec.rb
|
| |
| |
| |
| | |
timezone. TMail renders headers using localtime, which is not ideal, but we're migrating away from it anyway, so I'm not sure it's worth delving into the internals of TMail to fix it.
|
| | |
|
| |
| |
| |
| | |
Makes a simple model like Holiday pass, yay
|
|/
|
|
| |
We'll bring stuff from it back in gradually to remove unnecessary cruft
|
|\ |
|
| |
| |
| |
| |
| |
| | |
suite by ~35% on my machine
Via https://37signals.com/svn/posts/2742-the-road-to-faster-tests
|
|/
|
|
| |
just be loaded as binary.
|
|
|
|
| |
into it.
|
| |
|
| |
|
| |
|
|
|
|
| |
problem testing template results
|
|
|
|
| |
it less brittle.
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
spec/controllers/request_controller_spec.rb
|
| | |
|
|/
|
|
| |
Next step: making it asynchronous, e.g. with a queue of things to purge via a cron job.
|
|
|
|
|
|
|
|
|
| |
The ad hoc specification of fixtures has been an ongoing source
of bugs in the tests. The straw that broke the camel’s back is
that 7c6eb09 requires the fixtures to be loaded in order (i.e.
children before their parents), and it would have been a painful
process to reorder all the dozens of different fixture lists,
but the test system ought to be more reliable this way.
|
|
|
|
| |
At the same time, cause the tests not to rely on WDTK data. Fixes #396
|
|
|
|
|
|
|
|
|
|
|
| |
Previously there was just one raw email, and the test code relied
on that fact. Generalise it to handle multiple raw emails.
This change causes a number of tests to fail, because it exposes
failures that should have happened when the second raw email was
added but were masked by the fact that the text of this second
raw email was never loaded. These failures will be fixed in the
next commit.
|